Changeset 191613 in webkit

Timestamp:

Oct 26, 2015 5:08:21 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Spacebar to start recording should not cause system beep
​https://bugs.webkit.org/show_bug.cgi?id=150573

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-26
Reviewed by Timothy Hatcher.

• UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel.prototype._toggleRecordingOnSpacebar):
(WebInspector.TimelineSidebarPanel.prototype._toggleNewRecordingOnSpacebar):
The keyboard shortcuts do not implicitly prevent default because they may bail.
So in cases where they do handle the key, prevent default to prevent system beeps.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TimelineSidebarPanel.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-10-26  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Spacebar to start recording should not cause system beep
+        https://bugs.webkit.org/show_bug.cgi?id=150573
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/TimelineSidebarPanel.js:
+        (WebInspector.TimelineSidebarPanel.prototype._toggleRecordingOnSpacebar):
+        (WebInspector.TimelineSidebarPanel.prototype._toggleNewRecordingOnSpacebar):
+        The keyboard shortcuts do not implicitly prevent default because they may bail.
+        So in cases where they do handle the key, prevent default to prevent system beeps.
+
 2015-10-26  Matt Baker  <mattbaker@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js

@@ -533 +533 @@
 
         this._toggleRecording();
+
+        event.preventDefault();
     }
 
@@ -541 +543 @@
 
         this._toggleRecording(true);
+
+        event.preventDefault();
     }