Changeset 19203 in webkit

Timestamp:

Jan 28, 2007 6:30:42 PM (17 years ago)

Author:

ddkilzer

Message:

JavaScriptCore:

Reviewed by Darin.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=9815 JavaScript TypeError loading Dean Edwards' JS compressor/obfuscator

Creating a function using 'new Function()' was not setting its prototype with the
same flags as 'function() { }'.

Test: fast/js/function-prototype.html

• kjs/function_object.cpp: (FunctionObjectImp::construct): Change flags from DontEnum|DontDelete|ReadOnly to Internal|DontDelete to match FuncDeclNode::processFuncDecl() and FuncExprNode::evaluate() in kjs/nodes.cpp.

LayoutTests:

Reviewed by Darin.

• Test for ​http://bugs.webkit.org/show_bug.cgi?id=9815 JavaScript TypeError loading Dean Edwards' JS compressor/obfuscator

• fast/js/function-prototype-expected.txt: Added.
• fast/js/function-prototype.html: Added.

Location:

trunk

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/kjs/function_object.cpp (modified) (1 diff)
• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/js/function-prototype-expected.txt (added)
• LayoutTests/fast/js/function-prototype.html (added)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2007-01-28  David Kilzer  <ddkilzer@webkit.org>
+
+        Reviewed by Darin.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=9815
+          JavaScript TypeError loading Dean Edwards' JS compressor/obfuscator
+
+        Creating a function using 'new Function()' was not setting its prototype with the
+        same flags as 'function() { }'.
+
+        Test: fast/js/function-prototype.html
+
+        * kjs/function_object.cpp:
+        (FunctionObjectImp::construct): Change flags from DontEnum|DontDelete|ReadOnly to
+        Internal|DontDelete to match FuncDeclNode::processFuncDecl() and
+        FuncExprNode::evaluate() in kjs/nodes.cpp.
+
 2007-01-27  Geoffrey Garen  <ggaren@apple.com>
 

trunk/JavaScriptCore/kjs/function_object.cpp

@@ -246 +246 @@
   JSObject *prototype = objCons->construct(exec,List::empty());
   prototype->put(exec, constructorPropertyName, fimp, DontEnum|DontDelete|ReadOnly);
-  fimp->put(exec, prototypePropertyName, prototype, DontEnum|DontDelete|ReadOnly);
+  fimp->put(exec, prototypePropertyName, prototype, Internal|DontDelete);
   return fimp;
 }

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-01-28  David Kilzer  <ddkilzer@webkit.org>
+
+        Reviewed by Darin.
+
+        - Test for http://bugs.webkit.org/show_bug.cgi?id=9815
+          JavaScript TypeError loading Dean Edwards' JS compressor/obfuscator
+
+        * fast/js/function-prototype-expected.txt: Added.
+        * fast/js/function-prototype.html: Added.
+
 2007-01-28  Alexey Proskuryakov  <ap@webkit.org>