Changeset 192528 in webkit

Timestamp:

Nov 17, 2015 1:31:57 PM (8 years ago)

Author:

ggaren@apple.com

Message:

A window with a hung tab waits 5s before closing
​https://bugs.webkit.org/show_bug.cgi?id=151319

Reviewed by Anders Carlsson.

I manually tested that I did not break unload events upon window close
by running run-webkit-httpd and invoking a 1x1 image load of
​http://127.0.0.1:8000/navigation/resources/save-Ping.php from an unload
handler.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::tryClose): Use the sudden termination bit to
close without waiting for a response.

• UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::isSuddenTerminationEnabled): Expose the bit.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (1 diff)
• UIProcess/WebProcessProxy.h (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-11-17  Geoffrey Garen  <ggaren@apple.com>
+
+        A window with a hung tab waits 5s before closing
+        https://bugs.webkit.org/show_bug.cgi?id=151319
+
+        Reviewed by Anders Carlsson.
+
+        I manually tested that I did not break unload events upon window close
+        by running run-webkit-httpd and invoking a 1x1 image load of
+        http://127.0.0.1:8000/navigation/resources/save-Ping.php from an unload
+        handler.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::tryClose): Use the sudden termination bit to
+        close without waiting for a response.
+
+        * UIProcess/WebProcessProxy.h:
+        (WebKit::WebProcessProxy::isSuddenTerminationEnabled): Expose the bit.
+
 2015-11-17  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

@@ -862 +862 @@
         return true;
 
+    // Close without delay if the process allows it. Our goal is to terminate
+    // the process, so we check a per-process status bit.
+    if (m_process->isSuddenTerminationEnabled())
+        return true;
+
     m_process->send(Messages::WebPage::TryClose(), m_pageID);
     m_process->responsivenessTimer().start();

trunk/Source/WebKit2/UIProcess/WebProcessProxy.h

@@ -132 +132 @@
     void enableSuddenTermination();
     void disableSuddenTermination();
+    bool isSuddenTerminationEnabled() { return !m_numberOfTimesSuddenTerminationWasDisabled; }
 
     void requestTermination();