Changeset 192675 in webkit


Ignore:
Timestamp:
Nov 19, 2015 8:51:18 PM (8 years ago)
Author:
adam.bergkvist@ericsson.com
Message:

WebRTC: Initial testing of updated RTCPeerConnection API
​https://bugs.webkit.org/show_bug.cgi?id=151304

Reviewed by Eric Carlson.

Source/WebCore:

Remove faulty ASSERT since the selector argument to
RTCPeerConnection.getStats() is nullable. Also use
pointers instead of a ref (for the same reason).

Tests: Unskip two crashing tests.

  • Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::getStats):

  • Modules/mediastream/MediaEndpointPeerConnection.h:
  • Modules/mediastream/PeerConnectionBackend.h:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::privateGetStats):

LayoutTests:

Unskip two previously crashing tests.
fast/mediastream/RTCPeerConnection-overloaded-operations.html
fast/mediastream/RTCPeerConnection-overloaded-operations-params.html

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r192671 r192675  
     12015-11-19  Adam Bergkvist  <adam.bergkvist@ericsson.com>
     2
     3        WebRTC: Initial testing of updated RTCPeerConnection API
     4        https://bugs.webkit.org/show_bug.cgi?id=151304
     5
     6        Reviewed by Eric Carlson.
     7
     8        Unskip two previously crashing tests.
     9        fast/mediastream/RTCPeerConnection-overloaded-operations.html
     10        fast/mediastream/RTCPeerConnection-overloaded-operations-params.html
     11
     12        * platform/mac-wk2/TestExpectations:
     13        * platform/mac/TestExpectations:
     14
    1152015-11-19  Saam barati  <sbarati@apple.com>
    216

  • trunk/LayoutTests/platform/mac-wk2/TestExpectations

    r192652 r192675  
    566566imported/blink/fast/multicol/span/adjacent-spanners-with-margin.html [ Pass ImageOnlyFailure ]
    567567imported/blink/fast/overflow/hidden-html-auto-body.html [ Pass ImageOnlyFailure ]
    568 
    569 webkit.org/b/151304 [ Debug ] fast/mediastream/RTCPeerConnection-overloaded-operations-params.html [ Pass Crash ]
    570 webkit.org/b/151304 [ Debug ] fast/mediastream/RTCPeerConnection-overloaded-operations.html [ Pass Crash ]

  • trunk/LayoutTests/platform/mac/TestExpectations

    r192670 r192675  
    192192fast/mediastream/RTCPeerConnection-localDescription.html
    193193fast/mediastream/RTCPeerConnection-onnegotiationneeded.html
    194 fast/mediastream/RTCPeerConnection-overloaded-operations.html
    195 fast/mediastream/RTCPeerConnection-overloaded-operations-params.html
    196194fast/mediastream/RTCPeerConnection-remoteDescription.html
    197195fast/mediastream/RTCPeerConnection-stats.html

  • trunk/Source/WebCore/ChangeLog

    r192672 r192675  
     12015-11-19  Adam Bergkvist  <adam.bergkvist@ericsson.com>
     2
     3        WebRTC: Initial testing of updated RTCPeerConnection API
     4        https://bugs.webkit.org/show_bug.cgi?id=151304
     5
     6        Reviewed by Eric Carlson.
     7
     8        Remove faulty ASSERT since the selector argument to
     9        RTCPeerConnection.getStats() is nullable. Also use
     10        pointers instead of a ref (for the same reason).
     11
     12        Tests: Unskip two crashing tests.
     13
     14        * Modules/mediastream/MediaEndpointPeerConnection.cpp:
     15        (WebCore::MediaEndpointPeerConnection::getStats):
     16        * Modules/mediastream/MediaEndpointPeerConnection.h:
     17        * Modules/mediastream/PeerConnectionBackend.h:
     18        * Modules/mediastream/RTCPeerConnection.cpp:
     19        (WebCore::RTCPeerConnection::privateGetStats):
     20
    1212015-11-19  Hunseop Jeong  <hs85.jeong@samsung.com>
    222

  • trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp

    r192575 r192675  
    147147}
    148148
    149 void MediaEndpointPeerConnection::getStats(MediaStreamTrack&, PeerConnection::StatsPromise&& promise)
     149void MediaEndpointPeerConnection::getStats(MediaStreamTrack*, PeerConnection::StatsPromise&& promise)
    150150{
    151151    notImplemented();

  • trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.h

    r192575 r192675  
    6363    void addIceCandidate(RTCIceCandidate&, PeerConnection::VoidPromise&&) override;
    6464
    65     void getStats(MediaStreamTrack&, PeerConnection::StatsPromise&&) override;
     65    void getStats(MediaStreamTrack*, PeerConnection::StatsPromise&&) override;
    6666
    6767    void stop() override;

  • trunk/Source/WebCore/Modules/mediastream/PeerConnectionBackend.h

    r192464 r192675  
    100100    virtual void addIceCandidate(RTCIceCandidate&, PeerConnection::VoidPromise&&) = 0;
    101101
    102     virtual void getStats(MediaStreamTrack&, PeerConnection::StatsPromise&&) = 0;
     102    virtual void getStats(MediaStreamTrack*, PeerConnection::StatsPromise&&) = 0;
    103103
    104104    virtual void stop() = 0;

  • trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp

    r192464 r192675  
    358358void RTCPeerConnection::privateGetStats(MediaStreamTrack* selector, PeerConnection::StatsPromise&& promise)
    359359{
    360     ASSERT(selector);
    361     m_backend->getStats(*selector, WTF::move(promise));
     360    m_backend->getStats(selector, WTF::move(promise));
    362361}
    363362
Note: See TracChangeset for help on using the changeset viewer.