Changeset 19270 in webkit

Timestamp:

Jan 30, 2007 2:36:05 PM (17 years ago)

Author:

weinig

Message:

LayoutTests:

Reviewed by Darin (by way of Hyatt).

• test for ​http://bugs.webkit.org/show_bug.cgi?id=12373 ASSERTION FAILURE: !child->needsLayout() on paypal.com

• fast/table/inline-form-assert-expected.checksum: Added.
• fast/table/inline-form-assert-expected.png: Added.
• fast/table/inline-form-assert-expected.txt: Added.
• fast/table/inline-form-assert.html: Added.

WebCore:

Reviewed by Darin (by way of Hyatt).

• fix ​http://bugs.webkit.org/show_bug.cgi?id=12373 ASSERTION FAILURE: !child->needsLayout() on paypal.com

Test: fast/table/inline-form-assert.html

• rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout): Changed the assertion to ignore inlines.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/table/inline-form-assert-expected.checksum (added)
• LayoutTests/fast/table/inline-form-assert-expected.png (added)
• LayoutTests/fast/table/inline-form-assert-expected.txt (added)
• LayoutTests/fast/table/inline-form-assert.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderContainer.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-01-30  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Darin (by way of Hyatt).
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=12373
+          ASSERTION FAILURE: !child->needsLayout() on paypal.com
+
+        * fast/table/inline-form-assert-expected.checksum: Added.
+        * fast/table/inline-form-assert-expected.png: Added.
+        * fast/table/inline-form-assert-expected.txt: Added.
+        * fast/table/inline-form-assert.html: Added.
+
 2007-01-30  Alexey Proskuryakov  <ap@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-01-30  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Darin (by way of Hyatt).
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=12373
+          ASSERTION FAILURE: !child->needsLayout() on paypal.com
+
+        Test: fast/table/inline-form-assert.html
+
+        * rendering/RenderContainer.cpp:
+        (WebCore::RenderContainer::layout): Changed the assertion to ignore inlines.
+
 2007-01-30  Alexey Proskuryakov  <ap@webkit.org>
 

trunk/WebCore/rendering/RenderContainer.cpp

@@ -477 +477 @@
     while (child) {
         child->layoutIfNeeded();
-        ASSERT(!child->needsLayout());
+        ASSERT(child->isRenderInline() || !child->needsLayout());
         child = child->nextSibling();
     }