Changeset 192731 in webkit


Ignore:
Timestamp:
Nov 22, 2015 2:48:48 AM (8 years ago)
Author:
Carlos Garcia Campos
Message:

Unreviewed, rolling out r192727.

It made the selections transparent again and broke
/webkit2/WebKitWebView/snapshot

Reverted changeset:

"[GTK] RenderThemeGtk::platformActiveSelectionBackgroundColor,
et. al. should not clobber state of cached GtkStyleContexts"
https://bugs.webkit.org/show_bug.cgi?id=151533
http://trac.webkit.org/changeset/192727

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r192727 r192731  
     12015-11-22  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        Unreviewed, rolling out r192727.
     4
     5        It made the selections transparent again and broke
     6        /webkit2/WebKitWebView/snapshot
     7
     8        Reverted changeset:
     9
     10        "[GTK] RenderThemeGtk::platformActiveSelectionBackgroundColor,
     11        et. al. should not clobber state of cached GtkStyleContexts"
     12        https://bugs.webkit.org/show_bug.cgi?id=151533
     13        http://trac.webkit.org/changeset/192727
     14
    1152015-11-22  Michael Catanzaro  <mcatanzaro@igalia.com>
    216
  • trunk/Source/WebCore/rendering/RenderThemeGtk.cpp

    r192727 r192731  
    13491349static Color styleColor(GType widgetType, GtkStateFlags state, StyleColorType colorType)
    13501350{
     1351
    13511352    GtkStyleContext* context = getStyleContext(widgetType);
    1352     gtk_style_context_save(context);
     1353    // Recent GTK+ versions (> 3.14) require to explicitly set the state before getting the color.
    13531354    gtk_style_context_set_state(context, state);
    13541355
     
    13581359    else
    13591360        gtk_style_context_get_color(context, gtk_style_context_get_state(context), &gdkRGBAColor);
    1360 
    1361     gtk_style_context_restore(context);
    13621361    return gdkRGBAColor;
    13631362}
Note: See TracChangeset for help on using the changeset viewer.