Changeset 193642 in webkit
- Timestamp:
- Dec 7, 2015 11:48:37 AM (8 years ago)
- Location:
- trunk/Websites/webkit.org
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Websites/webkit.org/ChangeLog
r193536 r193642 1 2015-12-07 Jonathan Davis <jond@apple.com> 2 3 Address UX issues with the Contribute menu. 4 https://bugs.webkit.org/show_bug.cgi?id=151874 5 6 Reviewed by Timothy Hatcher. 7 8 * wp-content/themes/webkit/functions.php: 9 * wp-content/themes/webkit/header.php: 10 * wp-content/themes/webkit/style.css: 11 (time, mark, audio, video): 12 (footer, header, hgroup, menu, nav, section): 13 (html): 14 (body): 15 (ol, ul): 16 (blockquote, q): 17 (q:before, q:after): 18 (table): 19 (p:empty): 20 (.admin-bar p > a[name]::before): 21 (.screen-reader-text): 22 (.screen-reader-text:focus): 23 (pre): 24 (code): 25 (.feature-header:after): 26 (.feature.opened .feature-header:after): 27 (footer nav a:hover): 28 (header .menu-item-has-children .label-toggle::after): 29 (header .menu-item): 30 (.sub-menu-layer): 31 (.sub-menu-layer .menu-item:first-child): 32 (.menu > .menu-item > .menu-toggle:checked + .sub-menu): 33 (@media only screen and (max-width: 920px)): 34 (header .menu-item > .menu-toggle:checked + a > .label-toggle::after): 35 (header .menu): 36 (header .menu-toggle:checked ~ ul): 37 (header .sub-menu-layer:before): 38 (header .menu > .menu-item > .menu-toggle:checked ~ .sub-menu): 39 (footer nav li): 40 (@media only screen and (max-width: 690px)): 41 (.feature-filters:after): 42 (.feature-filters.opened:after): 43 (#wpadminbar): 44 (.table-of-contents label:after): 45 (.menu-toggle:checked ~ .table-of-contents label:after): 46 (.table-of-contents h6): 47 (header nav .menu-item-has-children .label-toggle): Deleted. 48 (header nav .menu-item): Deleted. 49 (header .menu > .menu-item-has-children:hover > a::before): Deleted. 50 (.menu > .menu-item > .menu-toggle:checked ~ .sub-menu): Deleted. 51 (header nav .menu-toggle:checked ~ ul): Deleted. 52 (header .menu-toggle:checked ~ .sub-menu): Deleted. 53 (@media only screen and (max-width: 782px)): Deleted. 54 1 55 2015-12-05 Timothy Hatcher <timothy@apple.com> 2 56 -
trunk/Websites/webkit.org/wp-content/themes/webkit/functions.php
r193387 r193642 211 211 public function start_lvl( &$output, $depth = 0, $args = array() ) { 212 212 $output .= "\n" . str_repeat("\t", $depth); 213 if ( ! empty($this->toggleid) )214 $output .= "<input type=\"checkbox\" id=\"toggle-{$this->toggleid}\" class=\"menu-toggle\" />";215 213 $classes = array("sub-menu"); 216 214 if ( 0 == $depth ) { … … 233 231 234 232 if ( in_array('menu-item-has-children', $item->classes) && 0 == $depth ) { 233 $this->toggleid = $item->ID; 234 $args->before .= "<input type=\"checkbox\" id=\"toggle-{$item->ID}\" class=\"menu-toggle\" />"; 235 235 $args->link_before = "<label for=\"toggle-{$item->ID}\" class=\"label-toggle\">" . $args->link_before; 236 236 $args->link_after .= "</label>"; 237 $this->toggleid = $item->ID;238 237 $item->url = '#nav-sub-menu'; 239 238 } elseif ( in_array('menu-item-has-children', $item->classes) && 1 == $depth ) { -
trunk/Websites/webkit.org/wp-content/themes/webkit/header.php
r192832 r193642 34 34 'walker' => new Responsive_Toggle_Walker_Nav_Menu(), 35 35 'theme_location' => 'site-nav', 36 'items_wrap' => '< label for="%1$s-toggle" class="label-toggle main-menu" data-open="Main Menu" data-close="Close Menu" onclick></label><input type="checkbox" id="%1$s-toggle" class="menu-toggle" /><ul id="%1$s" class="%2$s" role="menubar">%3$s</ul>',36 'items_wrap' => '<input type="checkbox" id="%1$s-toggle" class="menu-toggle" /><label for="%1$s-toggle" class="label-toggle main-menu" data-open="Main Menu" data-close="Close Menu"></label><ul id="%1$s" class="%2$s" role="menubar">%3$s</ul>', 37 37 ) ); ?></nav> 38 38 </div> -
trunk/Websites/webkit.org/wp-content/themes/webkit/style.css
r193379 r193642 21 21 menu, nav, output, section, summary, 22 22 time, mark, audio, video { 23 24 25 26 27 23 margin: 0; 24 padding: 0; 25 border: 0; 26 font: inherit; 27 vertical-align: baseline; 28 28 } 29 29 /* HTML5 display-role reset for older browsers */ 30 30 article, aside, details, figcaption, figure, 31 31 footer, header, hgroup, menu, nav, section { 32 32 display: block; 33 33 } 34 34 html { … … 41 41 font-size: 1.6rem; 42 42 font-weight: 400; 43 43 line-height: 1.4; 44 44 } 45 45 ol, ul { 46 46 list-style: none; 47 47 } 48 48 blockquote, q { 49 49 quotes: none; 50 50 } 51 51 blockquote:before, blockquote:after, 52 52 q:before, q:after { 53 54 53 content: ''; 54 content: none; 55 55 } 56 56 table { 57 58 57 border-collapse: collapse; 58 border-spacing: 0; 59 59 } 60 60 p:empty { … … 137 137 138 138 .screen-reader-text { 139 140 141 142 143 139 clip: rect(1px, 1px, 1px, 1px); 140 position: absolute !important; 141 height: 1px; 142 width: 1px; 143 overflow: hidden; 144 144 } 145 145 146 146 .screen-reader-text:focus { 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 147 background-color: #f1f1f1; 148 border-radius: 3px; 149 box-shadow: 0 0 2px 2px rgba(0, 0, 0, 0.6); 150 clip: auto !important; 151 color: #21759b; 152 display: block; 153 font-size: 14px; 154 font-size: 0.875rem; 155 font-weight: bold; 156 height: auto; 157 left: 5px; 158 line-height: normal; 159 padding: 15px 23px 14px; 160 text-decoration: none; 161 top: 5px; 162 width: auto; 163 z-index: 100000; /* Above WP toolbar. */ 164 164 } 165 165 … … 691 691 pre { 692 692 width: calc(100% + 6rem); 693 693 overflow: auto; 694 694 -webkit-overflow-scrolling: touch; 695 695 background: #f2f2f2; 696 697 696 border: 1px solid #E6E6E6; 697 border-radius: 3px; 698 698 699 699 box-sizing: border-box; … … 704 704 code { 705 705 color: #555555; 706 706 font-size: 1.6rem; 707 707 line-height: 2.5rem; 708 708 } … … 1292 1292 1293 1293 .feature.opened .feature-header:after { 1294 1295 1296 1294 -webkit-transform: rotateX(-180deg); 1295 -moz-transform: rotateX(-180deg); 1296 transform: rotateX(-180deg); 1297 1297 perspective: 600; 1298 1298 } … … 1350 1350 } 1351 1351 1352 header nav .menu-item-has-children .label-toggle{1353 background: url('images/menu-down.svg') right 0.7remno-repeat;1354 background-size: 1 rem;1352 header .menu-item-has-children .label-toggle::after { 1353 background: url('images/menu-down.svg') no-repeat; 1354 background-size: 1.2rem; 1355 1355 display: inline-block; 1356 padding-right: 1.5rem; 1357 } 1358 1359 header nav .menu-item { /* add bottom dimension to main menu items */ 1356 padding-right: 1.2rem; 1357 padding-top: 0.8rem; 1358 margin-left: 0.5rem; 1359 margin-top: -0.1rem; 1360 content: ''; 1361 1362 -webkit-transition: transform 0.3s ease-out; 1363 -moz-transition: transform 0.3s ease-out; 1364 transition: transform 0.3s ease-out; 1365 } 1366 1367 header .menu-item { /* add bottom dimension to main menu items */ 1360 1368 padding-bottom: 3rem; 1361 1369 } 1362 1370 1363 1371 /* Improves mouse accessibility of menus */ 1364 header .menu > .menu-item-has-children:hover > a::before {1372 /*header .menu > .menu-item-has-children:hover > a::before { 1365 1373 position: absolute; 1366 1374 content: ''; … … 1371 1379 right: -3rem; 1372 1380 } 1373 1381 */ 1374 1382 .sub-menu-layer { 1375 1383 text-align: center; … … 1377 1385 box-sizing: border-box; 1378 1386 1379 width: 210px; 1380 margin-left: -110px; 1387 width: 21rem; 1388 margin-left: -11rem; 1389 margin-top: -99rem; 1381 1390 1382 1391 position: absolute; … … 1427 1436 1428 1437 .menu > .menu-item > a:focus ~ .sub-menu, 1429 .menu > .menu-item.open-menu > .sub-menu,1438 .menu > .menu-item.open-menu > .sub-menu, 1430 1439 .menu > .menu-item:hover > .sub-menu, 1431 .menu > .menu-item > .menu-toggle:checked ~.sub-menu {1440 .menu > .menu-item > .menu-toggle:checked + .sub-menu { 1432 1441 display: block; 1433 1442 box-sizing: border-box; … … 1435 1444 opacity: 1; 1436 1445 top: 8rem; 1446 margin-top: 0; 1437 1447 } 1438 1448 … … 1488 1498 @media only screen and (max-width: 920px) { 1489 1499 1490 header nav.main-menu.label-toggle {1500 .main-menu.label-toggle { 1491 1501 display: inline-block; 1492 1502 margin: 1.5rem 0 2.5rem; … … 1495 1505 background: url('images/menu-down.svg') no-repeat 50%; 1496 1506 cursor: pointer; 1507 1508 -webkit-transition: transform 0.3s ease-out; 1509 -moz-transition: transform 0.3s ease-out; 1510 transition: transform 0.3s ease-out; 1511 } 1512 1513 .menu-toggle:checked + .main-menu.label-toggle, 1514 header .menu-item > .menu-toggle:checked + a > .label-toggle::after { 1515 -webkit-transform: rotateX(-180deg); 1516 -moz-transform: rotateX(-180deg); 1517 transform: rotateX(-180deg); 1518 perspective: 600; 1497 1519 } 1498 1520 … … 1512 1534 } 1513 1535 1514 header nav.menu-toggle:checked ~ ul {1536 header .menu-toggle:checked ~ ul { 1515 1537 display: block; 1516 1538 opacity: 1; … … 1571 1593 } 1572 1594 1573 header .menu-toggle:checked ~ .sub-menu {1574 text-align: left;1575 }1576 1577 header .menu > .menu-item:hover > .sub-menu,1578 1595 header .menu > .menu-item > .menu-toggle:checked ~ .sub-menu { 1579 1596 position: relative; 1580 1597 top: 1.5rem; 1581 } 1582 1598 margin-top: 0; 1599 } 1600 1583 1601 footer nav li { 1584 1602 padding: 0 3rem 3rem 0; … … 1587 1605 } 1588 1606 1589 @media only screen and (max-width: 782px) {1607 @media only screen and (max-width: 690px) { 1590 1608 1591 1609 .featured-tile { … … 1699 1717 1700 1718 .feature-filters.opened:after { 1701 1702 1703 1719 -webkit-transform: rotateX(-180deg); 1720 -moz-transform: rotateX(-180deg); 1721 transform: rotateX(-180deg); 1704 1722 } 1705 1723 … … 1739 1757 1740 1758 .menu-toggle:checked ~ .table-of-contents label:after { 1741 1742 1743 1759 -webkit-transform: rotateX(-180deg); 1760 -moz-transform: rotateX(-180deg); 1761 transform: rotateX(-180deg); 1744 1762 } 1745 1763 … … 1857 1875 1858 1876 .menu-toggle:checked ~ .table-of-contents label:after { 1859 1860 1861 1877 -webkit-transform: rotateX(-180deg); 1878 -moz-transform: rotateX(-180deg); 1879 transform: rotateX(-180deg); 1862 1880 } 1863 1881
Note: See TracChangeset
for help on using the changeset viewer.