Changeset 193750 in webkit

Timestamp:

Dec 8, 2015 8:02:50 AM (8 years ago)

Author:

jdiggs@igalia.com

Message:

[EFL] some ax tests have been failed since r186692
​https://bugs.webkit.org/show_bug.cgi?id=146887

Reviewed by Mario Sanchez Prada.

Source/WebCore:

The tests were failing because there are now two WebCore accessibility
roles which need to implement the AtkTable interface: TableRole and
GridRole. Because the latter was not added in r186692, any tests with
ARIA role grid that accessed cells via coordinates stopped working.

No new tests; instead unskipped all the broken table tests which now pass.

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(getInterfaceMaskFromObject):

LayoutTests:

• platform/efl/TestExpectations: Removed failing tests.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/efl/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-12-08  Joanmarie Diggs  <jdiggs@igalia.com>
+
+        [EFL] some ax tests have been failed since r186692
+        https://bugs.webkit.org/show_bug.cgi?id=146887
+
+        Reviewed by Mario Sanchez Prada.
+
+        * platform/efl/TestExpectations: Removed failing tests.
+
 2015-12-08  Joanmarie Diggs  <jdiggs@igalia.com>
 

trunk/LayoutTests/platform/efl/TestExpectations

@@ -2344 +2344 @@
 
 webkit.org/b/146887 accessibility/aria-roledescription.html [ Failure ]
-webkit.org/b/146887 accessibility/aria-table-hierarchy.html [ Failure ]
-webkit.org/b/146887 accessibility/aria-table-with-presentational-elements.html [ Failure ]
-webkit.org/b/146887 accessibility/aria-tables.html [ Failure ]
 webkit.org/b/146887 accessibility/list-detection.html [ Failure ]
-webkit.org/b/146887 accessibility/poorly-formed-aria-table.html [ Failure ]
-webkit.org/b/146887 accessibility/roles-exposed.html [ Failure ]
-webkit.org/b/146887 accessibility/table-fallback-roles-expose-element-attributes.html [ Failure ]
-webkit.org/b/146887 accessibility/table-with-footer-section-above-body.html [ Failure ]
-webkit.org/b/146887 accessibility/table-with-missing-aria-role-rows.html [ Failure ]
 
 # This test hardcodes the result of a platform-dependent font lookup algorithm.

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-12-08  Joanmarie Diggs  <jdiggs@igalia.com>
+
+        [EFL] some ax tests have been failed since r186692
+        https://bugs.webkit.org/show_bug.cgi?id=146887
+
+        Reviewed by Mario Sanchez Prada.
+
+        The tests were failing because there are now two WebCore accessibility
+        roles which need to implement the AtkTable interface: TableRole and
+        GridRole. Because the latter was not added in r186692, any tests with
+        ARIA role grid that accessed cells via coordinates stopped working.
+
+        No new tests; instead unskipped all the broken table tests which now pass.
+
+        * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+        (getInterfaceMaskFromObject):
+
 2015-12-08  Gwang Yoon Hwang  <yoon@igalia.com>
 

trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp

@@ -1132 +1132 @@
 
     // Table
-    if (role == TableRole)
+    if (role == TableRole || role == GridRole)
         interfaceMask |= 1 << WAITable;