Changeset 19397 in webkit


Ignore:
Timestamp:
Feb 4, 2007 6:54:45 PM (17 years ago)
Author:
weinig
Message:

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12562
Fix test cases that are now spewing console errors that
they are not testing for

  • fast/events/iframe-object-onload-expected.txt:
  • fast/events/iframe-object-onload.html: Change nil to null.
  • fast/forms/display-none-in-onchange-keyboard-expected.txt:
  • fast/forms/display-none-in-onchange-keyboard.html: Add missing id to div, change its text, and change the resulting text.
  • fast/forms/input-text-click-inside-expected.checksum:
  • fast/forms/input-text-click-inside-expected.png:
  • fast/forms/input-text-click-inside-expected.txt:
  • fast/forms/input-text-click-inside.html: Change moveTo(x,y) to mouseMoveTo(x,y).
  • fast/forms/input-text-click-outside-expected.txt:
  • fast/forms/input-text-click-outside.html: Ditto.
  • fast/js/array-foreach-expected.txt:
  • fast/js/array-foreach.html: Add try-catch blocks to catch exceptions and print them and general cleanup.
  • fast/js/array-some-expected.txt:
  • fast/js/array-some.html: Ditto.
  • fast/table/click-near-anonymous-table-expected.checksum:
  • fast/table/click-near-anonymous-table-expected.png:
  • fast/table/click-near-anonymous-table-expected.txt:
  • fast/table/click-near-anonymous-table.html: Change timeForward(ms) to leapForward(ms) and change the amount of time from 500ms to 1000ms to avoid clicking.
Location:
trunk/LayoutTests
Files:
19 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r19391 r19397  
     12007-02-04  Sam Weinig  <sam@webkit.org>
     2
     3        Reviewed by Darin.
     4
     5        Patch for http://bugs.webkit.org/show_bug.cgi?id=12562
     6        Fix test cases that are now spewing console errors that
     7        they are not testing for
     8
     9        * fast/events/iframe-object-onload-expected.txt:
     10        * fast/events/iframe-object-onload.html: Change nil to null.
     11        * fast/forms/display-none-in-onchange-keyboard-expected.txt:
     12        * fast/forms/display-none-in-onchange-keyboard.html: Add missing id to div, change
     13        its text, and change the resulting text.
     14        * fast/forms/input-text-click-inside-expected.checksum:
     15        * fast/forms/input-text-click-inside-expected.png:
     16        * fast/forms/input-text-click-inside-expected.txt:
     17        * fast/forms/input-text-click-inside.html: Change moveTo(x,y) to mouseMoveTo(x,y).
     18        * fast/forms/input-text-click-outside-expected.txt:
     19        * fast/forms/input-text-click-outside.html: Ditto.
     20        * fast/js/array-foreach-expected.txt:
     21        * fast/js/array-foreach.html: Add try-catch blocks to catch exceptions and print them and
     22        general cleanup.
     23        * fast/js/array-some-expected.txt:
     24        * fast/js/array-some.html: Ditto.
     25        * fast/table/click-near-anonymous-table-expected.checksum:
     26        * fast/table/click-near-anonymous-table-expected.png:
     27        * fast/table/click-near-anonymous-table-expected.txt:
     28        * fast/table/click-near-anonymous-table.html: Change timeForward(ms) to leapForward(ms) and
     29        change the amount of time from 500ms to 1000ms to avoid clicking.
     30
    1312007-02-03  Geoffrey Garen  <ggaren@apple.com>
    232

  • trunk/LayoutTests/fast/events/iframe-object-onload-expected.txt

    r19343 r19397  
    1 CONSOLE MESSAGE: line 19: ReferenceError: Can't find variable: nil
    21This test checks that onload events fire on iframe and object elements when their contents finish loading, and that these are separate event objects from those that fire on the body inside the frame. If it passes, you will see 6 blocks below, each with a three-line message that ends in false.
    32Fired load event on body inside iframe

  • trunk/LayoutTests/fast/events/iframe-object-onload.html

    r12587 r19397  
    1717}
    1818
    19 var innerEvent = nil;
     19var innerEvent = null;
    2020
    2121function logOuter(msg, event)

  • trunk/LayoutTests/fast/forms/display-none-in-onchange-keyboard-expected.txt

    r19343 r19397  
    1 CONSOLE MESSAGE: line 20: Null value
    21
    32This tests that setting display to 'none' for an element that's about to get focus doesn't crash.

  • trunk/LayoutTests/fast/forms/display-none-in-onchange-keyboard.html

    r15530 r19397  
    1818        eventSender.keyDown('\t', new Array());
    1919
    20         document.getElementById('result').innerHTML = 'SUCCESS';       
     20        document.getElementById('result').innerHTML = "SUCCESS - Didn't crash";
    2121    }
    2222    </script>
    … …  
    2525    <input id="first" type="text" onchange="document.getElementById('u').style.display='none'"><input id="u" type="text">
    2626    <p>This tests that setting display to 'none' for an element that's about to get focus doesn't crash.</p>
    27     <div>SUCCESS - Didn't crash</div>
     27    <div id="result">THE TEST DID NOT RUN</div>
    2828</body>
    2929</html>

  • trunk/LayoutTests/fast/forms/input-text-click-inside-expected.checksum

    r14936 r19397  
    1 aba36613297b546d1d1100c7c45ed4ef
     16564425bebc5b7787fd842f379396474

  • trunk/LayoutTests/fast/forms/input-text-click-inside-expected.txt

    r19343 r19397  
    1 CONSOLE MESSAGE: line 5: TypeError: Value undefined (result of expression eventSender.moveTo) is not object.
    21layer at (0,0) size 800x600
    32  RenderView at (0,0) size 800x600
    … …  
    1312layer at (38,38) size 142x13
    1413  RenderBlock {DIV} at (3,3) size 142x13
     14caret: position 0 of child 0 {DIV} of child 0 {INPUT} of child 0 {DIV} of child 0 {BODY} of child 0 {HTML} of document

  • trunk/LayoutTests/fast/forms/input-text-click-inside.html

    r14172 r19397  
    33<script>
    44if (window.eventSender) {
    5     eventSender.moveTo(100, 45);
     5    eventSender.mouseMoveTo(100, 45);
    66    eventSender.mouseDown();
    77    eventSender.mouseUp();

  • trunk/LayoutTests/fast/forms/input-text-click-outside-expected.txt

    r19343 r19397  
    1 CONSOLE MESSAGE: line 5: TypeError: Value undefined (result of expression eventSender.moveTo) is not object.
    21layer at (0,0) size 800x600
    32  RenderView at (0,0) size 800x600
    … …  
    1312layer at (38,38) size 142x13
    1413  RenderBlock {DIV} at (3,3) size 142x13
     14caret: position 1 of child 0 {INPUT} of child 0 {DIV} of child 0 {BODY} of child 0 {HTML} of document

  • trunk/LayoutTests/fast/forms/input-text-click-outside.html

    r14172 r19397  
    33<script>
    44if (window.eventSender) {
    5     eventSender.moveTo(225, 45);
     5    eventSender.mouseMoveTo(200, 45);
    66    eventSender.mouseDown();
    77    eventSender.mouseUp();

  • trunk/LayoutTests/fast/js/array-foreach-expected.txt

    r19343 r19397  
    1 CONSOLE MESSAGE: line 100: ReferenceError: Can't find variable: exception
    211.0 Single Argument Testing
    32The following tests forEach with one argument, the callback. It should print the contents of the array [2, 5, 9] alongside each index.
    … …  
    4241[0] is 2
    4342[1] is 5
     43Exception thrown, execution halted!
    4444
    45455.0 Wrong Type for Callback Test This test sends in incorrect types for the callback parameter of forEach. An exception should be thrown in each case. There should be 6 type errors (and no crashes!):

  • trunk/LayoutTests/fast/js/array-foreach.html

    r11995 r19397  
    77}
    88
    9 if (window.layoutTestController)  layoutTestController.dumpAsText();
     9if (window.layoutTestController)
     10    layoutTestController.dumpAsText();
    1011</script>
    1112</head>
    … …  
    7576function printEltAndChange(element, index, array) {
    7677    print("[" + index + "] is " + element);
    77     array[array.length-1-index]= "changed";
     78    array[array.length - 1 - index] = "changed";
    7879}
    7980
    … …  
    8687function printEltAndException(element, index, array) {
    8788    print("[" + index + "] is " + element);
    88     if(index==1) throw exception();
     89    if (index == 1)
     90        throw "Exception thrown, execution halted!";
    8991}
     92try {
     93    [2, 5, 9].forEach(printEltAndException);
     94} catch (e) {
     95    print(e);
     96}
     97</script>
    9098
    91 [2, 5, 9].forEach(printEltAndException);
    92 </script>
    9399<br/>
    941005.0 Wrong Type for Callback Test
    … …  
    96102<script>
    97103
    98 try { [2, 5, 9].forEach(5); }
    99 catch (e) { print(e); }
     104try {
     105    [2, 5, 9].forEach(5);
     106} catch (e) {
     107    print(e);
     108}
    100109
    101 try { [2, 5, 9].forEach("wrong"); }
    102 catch (e) { print(e); }
     110try {
     111    [2, 5, 9].forEach("wrong");
     112} catch (e) {
     113    print(e);
     114}
    103115
    104 try { [2, 5, 9].forEach(new Object()); }
    105 catch (e) { print(e); }
     116try {
     117    [2, 5, 9].forEach(new Object());
     118} catch (e) {
     119    print(e);
     120}
    106121
    107 try { [2, 5, 9].forEach(null); }
    108 catch (e) { print(e); }
     122try {
     123    [2, 5, 9].forEach(null);
     124} catch (e) {
     125    print(e);
     126}
    109127
    110 try { [2, 5, 9].forEach(undefined); }
    111 catch (e) { print(e) }
     128try {
     129    [2, 5, 9].forEach(undefined);
     130} catch (e) {
     131    print(e)
     132}
    112133
    113 try { [2, 5, 9].forEach(); }
    114 catch (e) { print(e); }
     134try {
     135    [2, 5, 9].forEach();
     136} catch (e) {
     137    print(e);
     138}
    115139
    116140</script>

  • trunk/LayoutTests/fast/js/array-some-expected.txt

    r19343 r19397  
    1 CONSOLE MESSAGE: line 100: ReferenceError: Can't find variable: isBigEnoughAndException
    211.0 Single Argument Testing
    32The following tests every with one argument, the callback. It should print whether the arrays [2, 5, 8, 1, 4] and [12, 5, 8, 1, 44] contain any numbers >= to 10 (false and true, respectively).
    … …  
    3433
    35344.0 Exception Test
    36 This test uses a function that throws an exception, and thus halts the execution of some. There should thus be no output.
     35This test uses a function that throws an exception, and thus halts the execution of some. There should be 2 exceptions thrown.
    3736
     37Exception thrown, execution halted!
     38Exception thrown, execution halted!
    3839
    39405.0 Wrong Type for Callback Test

  • trunk/LayoutTests/fast/js/array-some.html

    r11995 r19397  
    77}
    88
    9 if (window.layoutTestController)  layoutTestController.dumpAsText();
     9if (window.layoutTestController)
     10    layoutTestController.dumpAsText();
    1011</script>
    1112</head>
    … …  
    7273<script>
    7374function isBigEnoughAndChange(element, index, array) {
    74     array[array.length-1-index]= 10;
     75    array[array.length - 1 - index] = 10;
    7576    return (element >= 10);
    7677}
    … …  
    8182<br/>
    82834.0 Exception Test<br/>
    83 This test uses a function that throws an exception, and thus halts the execution of some.  There should thus be no output.<br/><br/>
     84This test uses a function that throws an exception, and thus halts the execution of some.  There should be 2 exceptions thrown.<br/><br/>
    8485<script>
    85 function isBigEnough(element, index, array) {
    86     throw exception();
     86function isBigEnoughAndException(element, index, array) {
     87    throw "Exception thrown, execution halted!";
    8788    return (element >= 10);
    8889}
    8990
    90 print([2, 5, 8, 1, 4].some(isBigEnoughAndException));
    91 print([12, 5, 8, 1, 44].some(isBigEnoughAndException));
     91try {
     92    [2, 5, 8, 1, 4].some(isBigEnoughAndException);
     93} catch (e) {
     94    print(e);
     95}
     96
     97try {
     98    [12, 5, 8, 1, 44].some(isBigEnoughAndException);
     99} catch (e) {
     100    print(e);
     101}
    92102
    93103</script>
    … …  
    97107<script>
    98108
    99 try { [12, 5, 8, 1, 44].some(5) }
    100 catch (e) { print(e); }
     109try {
     110    [12, 5, 8, 1, 44].some(5)
     111} catch (e) {
     112    print(e);
     113}
    101114
    102 try { [12, 5, 8, 1, 44].some("wrong"); }
    103 catch (e) { print(e); }
     115try {
     116    [12, 5, 8, 1, 44].some("wrong");
     117} catch (e) {
     118    print(e);
     119}
    104120
    105 try { [12, 5, 8, 1, 44].some(new Object()); }
    106 catch (e) { print(e); }
     121try {
     122    [12, 5, 8, 1, 44].some(new Object());
     123} catch (e) {
     124    print(e);
     125}
    107126
    108 try { [12, 5, 8, 1, 44].some(null); }
    109 catch (e) { print(e); }
     127try {
     128    [12, 5, 8, 1, 44].some(null);
     129} catch (e) {
     130    print(e);
     131}
    110132
    111 try { [12, 5, 8, 1, 44].some(undefined); }
    112 catch (e) { print(e) }
     133try {
     134    [12, 5, 8, 1, 44].some(undefined);
     135} catch (e) {
     136    print(e)
     137}
    113138
    114 try { [12, 5, 8, 1, 44].some(); }
    115 catch (e) { print(e); }
     139try {
     140    [12, 5, 8, 1, 44].some();
     141} catch (e) {
     142    print(e);
     143}
    116144
    117145</script>
    … …  
    121149<script>
    122150function isBigEnough(element, index, array) {
    123     print("Testing element "+element+"...");
     151    print("Testing element " + element + "...");
    124152    return (element >= 10);
    125153}

  • trunk/LayoutTests/fast/table/click-near-anonymous-table-expected.checksum

    r15425 r19397  
    1 5229184684e7a329c7988e1e7e10a9d0
     17e58fe2709accf3efb12e524a46a1117

  • trunk/LayoutTests/fast/table/click-near-anonymous-table-expected.txt

    r19343 r19397  
    1 CONSOLE MESSAGE: line 18: Value undefined (result of expression eventSender.timeForward) is not object.
    21layer at (0,0) size 800x600
    32  RenderView at (0,0) size 800x600
    … …  
    4140                RenderText {#text} at (0,0) size 176x18
    4241                  text run at (0,0) width 176: "Click to the right of this text"
    43 caret: position 9 of child 0 {#text} of child 7 {DIV} of child 7 {DIV} of child 1 {BODY} of child 0 {HTML} of document
     42caret: position 40 of child 0 {#text} of child 3 {DIV} of child 7 {DIV} of child 1 {BODY} of child 0 {HTML} of document

  • trunk/LayoutTests/fast/table/click-near-anonymous-table.html

    r19149 r19397  
    1616                eventSender.mouseDown();
    1717                eventSender.mouseUp();
    18                 eventSender.timeForward(500);   // we're not multi-clicking
     18                eventSender.leapForward(1000);   // we're not multi-clicking
    1919            }
    2020        }
Note: See TracChangeset for help on using the changeset viewer.