Changeset 193972 in webkit
- Timestamp:
- Dec 11, 2015 12:56:12 PM (8 years ago)
- Location:
- trunk
- Files:
-
- 13 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/JavaScriptCore/ChangeLog
r193955 r193972 1 2015-12-11 Joseph Pecoraro <pecoraro@apple.com> 2 3 check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones 4 https://bugs.webkit.org/show_bug.cgi?id=152156 5 6 Reviewed by Dan Bernstein. 7 8 * llvm/InitializeLLVMMac.cpp: 9 Remove stale comment. The ObjC class this comment referenced 10 has already been removed. 11 1 12 2015-12-11 Benjamin Poulain <benjamin@webkit.org> 2 13 -
trunk/Source/JavaScriptCore/llvm/InitializeLLVMMac.cpp
r182483 r193972 33 33 #include <wtf/StringPrintStream.h> 34 34 35 // Use the "JS" prefix to make check-for-inappropriate-objc-class-names happy. I36 // think this is better than hacking that script.37 38 35 namespace JSC { 39 36 -
trunk/Source/WebCore/ChangeLog
r193970 r193972 1 2015-12-11 Joseph Pecoraro <pecoraro@apple.com> 2 3 check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones 4 https://bugs.webkit.org/show_bug.cgi?id=152156 5 6 Reviewed by Dan Bernstein. 7 8 * platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h: 9 * platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm: 10 (WebCore::CDMSessionAVContentKeySession::CDMSessionAVContentKeySession): 11 * platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h: 12 * platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm: 13 (WebCore::CDMSessionAVStreamSession::CDMSessionAVStreamSession): 14 Rename classes with a "Web" prefix. 15 1 16 2015-12-11 Brady Eidson <beidson@apple.com> 2 17 -
trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h
r193479 r193972 35 35 OBJC_CLASS AVContentKeyRequest; 36 36 OBJC_CLASS AVContentKeySession; 37 OBJC_CLASS CDMSessionAVContentKeySessionDelegate;37 OBJC_CLASS WebCDMSessionAVContentKeySessionDelegate; 38 38 39 39 namespace WebCore { … … 67 67 68 68 RetainPtr<AVContentKeySession> m_contentKeySession; 69 RetainPtr< CDMSessionAVContentKeySessionDelegate> m_contentKeySessionDelegate;69 RetainPtr<WebCDMSessionAVContentKeySessionDelegate> m_contentKeySessionDelegate; 70 70 RetainPtr<AVContentKeyRequest> m_keyRequest; 71 71 RefPtr<Uint8Array> m_initData; -
trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm
r193479 r193972 81 81 @end 82 82 83 @interface CDMSessionAVContentKeySessionDelegate : NSObject {83 @interface WebCDMSessionAVContentKeySessionDelegate : NSObject { 84 84 WebCore::CDMSessionAVContentKeySession *m_parent; 85 85 } … … 87 87 @end 88 88 89 @implementation CDMSessionAVContentKeySessionDelegate89 @implementation WebCDMSessionAVContentKeySessionDelegate 90 90 - (id)initWithParent:(WebCore::CDMSessionAVContentKeySession *)parent 91 91 { … … 126 126 CDMSessionAVContentKeySession::CDMSessionAVContentKeySession(const Vector<int>& protocolVersions, CDMPrivateMediaSourceAVFObjC& cdm, CDMSessionClient* client) 127 127 : CDMSessionMediaSourceAVFObjC(cdm, client) 128 , m_contentKeySessionDelegate(adoptNS([[ CDMSessionAVContentKeySessionDelegate alloc] initWithParent:this]))128 , m_contentKeySessionDelegate(adoptNS([[WebCDMSessionAVContentKeySessionDelegate alloc] initWithParent:this])) 129 129 , m_protocolVersions(protocolVersions) 130 130 , m_mode(Normal) -
trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h
r193479 r193972 35 35 36 36 OBJC_CLASS AVStreamSession; 37 OBJC_CLASS CDMSessionAVStreamSessionObserver;37 OBJC_CLASS WebCDMSessionAVStreamSessionObserver; 38 38 39 39 namespace WebCore { … … 66 66 RefPtr<Uint8Array> m_certificate; 67 67 RetainPtr<NSData> m_expiredSession; 68 RetainPtr< CDMSessionAVStreamSessionObserver> m_dataParserObserver;68 RetainPtr<WebCDMSessionAVStreamSessionObserver> m_dataParserObserver; 69 69 Vector<int> m_protocolVersions; 70 70 enum { Normal, KeyRelease } m_mode; -
trunk/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm
r193479 r193972 67 67 @end 68 68 69 @interface CDMSessionAVStreamSessionObserver : NSObject {69 @interface WebCDMSessionAVStreamSessionObserver : NSObject { 70 70 WebCore::CDMSessionAVStreamSession *m_parent; 71 71 } 72 72 @end 73 73 74 @implementation CDMSessionAVStreamSessionObserver74 @implementation WebCDMSessionAVStreamSessionObserver 75 75 - (id)initWithParent:(WebCore::CDMSessionAVStreamSession *)parent 76 76 { … … 99 99 : CDMSessionMediaSourceAVFObjC(cdm, client) 100 100 , m_weakPtrFactory(this) 101 , m_dataParserObserver(adoptNS([[ CDMSessionAVStreamSessionObserver alloc] initWithParent:this]))101 , m_dataParserObserver(adoptNS([[WebCDMSessionAVStreamSessionObserver alloc] initWithParent:this])) 102 102 , m_protocolVersions(protocolVersions) 103 103 , m_mode(Normal) -
trunk/Source/WebKit2/ChangeLog
r193944 r193972 1 2015-12-11 Joseph Pecoraro <pecoraro@apple.com> 2 3 check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones 4 https://bugs.webkit.org/show_bug.cgi?id=152156 5 6 Reviewed by Dan Bernstein. 7 8 * UIProcess/ios/WebVideoFullscreenManagerProxy.mm: 9 (WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID): 10 * UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h: 11 * UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm: 12 (WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy): 13 Rename internal classes with "_WK" prefix. 14 1 15 2015-12-10 Eric Carlson <eric.carlson@apple.com> 2 16 -
trunk/Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm
r193370 r193972 40 40 #import <WebKitSystemInterface.h> 41 41 42 @interface W ebLayerHostView : UIView42 @interface WKLayerHostView : UIView 43 43 @property (nonatomic, assign) uint32_t contextID; 44 44 @end 45 45 46 @implementation W ebLayerHostView46 @implementation WKLayerHostView 47 47 48 48 + (Class)layerClass { … … 340 340 std::tie(model, interface) = ensureModelAndInterface(contextId); 341 341 342 RetainPtr<W ebLayerHostView> view = static_cast<WebLayerHostView*>(model->layerHostView());342 RetainPtr<WKLayerHostView> view = static_cast<WKLayerHostView*>(model->layerHostView()); 343 343 if (!view) { 344 view = adoptNS([[W ebLayerHostView alloc] init]);344 view = adoptNS([[WKLayerHostView alloc] init]); 345 345 model->setLayerHostView(view); 346 346 } -
trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h
r185967 r193972 33 33 #include <WebCore/IntSize.h> 34 34 35 OBJC_CLASS OneShotDisplayLinkHandler;35 OBJC_CLASS WKOneShotDisplayLinkHandler; 36 36 37 37 namespace WebKit { … … 108 108 CallbackMap m_callbacks; 109 109 110 RetainPtr< OneShotDisplayLinkHandler> m_displayLinkHandler;110 RetainPtr<WKOneShotDisplayLinkHandler> m_displayLinkHandler; 111 111 }; 112 112 -
trunk/Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm
r192712 r193972 46 46 // breaking WebKit1 behavior or WebKit2-WebKit1 coexistence. 47 47 #if PLATFORM(IOS) 48 @interface OneShotDisplayLinkHandler : NSObject {48 @interface WKOneShotDisplayLinkHandler : NSObject { 49 49 WebKit::RemoteLayerTreeDrawingAreaProxy* _drawingAreaProxy; 50 50 CADisplayLink *_displayLink; … … 58 58 @end 59 59 60 @implementation OneShotDisplayLinkHandler60 @implementation WKOneShotDisplayLinkHandler 61 61 62 62 - (id)initWithDrawingAreaProxy:(WebKit::RemoteLayerTreeDrawingAreaProxy*)drawingAreaProxy … … 105 105 , m_remoteLayerTreeHost(*this) 106 106 #if PLATFORM(IOS) 107 , m_displayLinkHandler(adoptNS([[ OneShotDisplayLinkHandler alloc] initWithDrawingAreaProxy:this]))107 , m_displayLinkHandler(adoptNS([[WKOneShotDisplayLinkHandler alloc] initWithDrawingAreaProxy:this])) 108 108 #endif 109 109 { -
trunk/Tools/ChangeLog
r193944 r193972 1 2015-12-11 Joseph Pecoraro <pecoraro@apple.com> 2 3 check-for-inappropriate-objc-class-names should check all class names, not just externally visible ones 4 https://bugs.webkit.org/show_bug.cgi?id=152156 5 6 Reviewed by Dan Bernstein. 7 8 Our frameworks should appropriately prefix all ObjC classes, 9 not just external symbols. 10 11 * Scripts/check-for-inappropriate-objc-class-names: 12 Remove the -g switch to check all ObjC class names. 13 1 14 2015-12-10 Eric Carlson <eric.carlson@apple.com> 2 15 -
trunk/Tools/Scripts/check-for-inappropriate-objc-class-names
r177949 r193972 61 61 62 62 if (!defined $executablePathAge || !defined $buildTimestampAge || $executablePathAge < $buildTimestampAge || $scriptAge < $buildTimestampAge) { 63 if (!open NM, "(nm -U gjp '$executablePath' | sed 's/^/STDOUT:/') 2>&1 |") {63 if (!open NM, "(nm -Ujp '$executablePath' | sed 's/^/STDOUT:/') 2>&1 |") { 64 64 print "ERROR: Could not open $executablePath\n"; 65 65 $sawError = 1;
Note: See TracChangeset
for help on using the changeset viewer.