Changeset 194015 in webkit


Ignore:
Timestamp:
Dec 13, 2015 6:07:40 AM (8 years ago)
Author:
jdiggs@igalia.com
Message:

AX: [EFL] Anonymous render block flow elements should be exposed as ATK_ROLE_SECTION; not ATK_ROLE_PANEL
​https://bugs.webkit.org/show_bug.cgi?id=152079

Reviewed by Chris Fleizach.

Source/WebCore:

Map the element to WebCore AccessibilityRole DivRole for EFL. As with GTK, this
is being done in the shared layer rather than in the platform layer because we
want all subsequent logic to treat anonymous render block flow elements as divs.

No new tests. We already have sufficient test coverage. The expectations
been updated accordingly.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

LayoutTests:

  • platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
  • platform/efl/accessibility/image-link-expected.txt: Updated.
  • platform/efl/accessibility/image-with-alt-and-map-expected.txt: Updated.
  • platform/efl/accessibility/lists-expected.txt: Updated.
  • platform/efl/accessibility/media-element-expected.txt: Updated
Location:
trunk
Files:
1 added
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r194014 r194015  
     12015-12-13  Joanmarie Diggs  <jdiggs@igalia.com>
     2
     3        AX: [EFL] Anonymous render block flow elements should be exposed as ATK_ROLE_SECTION; not ATK_ROLE_PANEL
     4        https://bugs.webkit.org/show_bug.cgi?id=152079
     5
     6        Reviewed by Chris Fleizach.
     7
     8        * platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
     9        * platform/efl/accessibility/image-link-expected.txt: Updated.
     10        * platform/efl/accessibility/image-with-alt-and-map-expected.txt: Updated.
     11        * platform/efl/accessibility/lists-expected.txt: Updated.
     12        * platform/efl/accessibility/media-element-expected.txt: Updated
     13
    1142015-12-13  Brady Eidson  <beidson@apple.com>
    215

  • trunk/LayoutTests/platform/efl/accessibility/image-link-expected.txt

    r193751 r194015  
    55
    66AXRole: AXLink
    7 AXParent: AXGroup
     7AXParent: AXSection
    88AXChildren: 1
    99AXPosition: { 0.000000, 0.000000 }

  • trunk/LayoutTests/platform/efl/accessibility/image-with-alt-and-map-expected.txt

    r176505 r194015  
    77
    88AXRole: AXWebArea AXTitle:  AXDescription:
    9   AXRole: AXGroup AXTitle:  AXDescription:
     9  AXRole: AXSection AXTitle:  AXDescription:
    1010    AXRole: AXImageMap AXTitle: foo bar baz AXDescription: foo bar baz
    1111      AXRole: AXLink AXTitle: foo AXDescription: foo

  • trunk/LayoutTests/platform/efl/accessibility/lists-expected.txt

    r193751 r194015  
    6666AXPlatformAttributes: tag:dl, toolkit:WebKitEfl
    6767------------
    68 AXRole: AXGroup
     68AXRole: AXSection
    6969AXParent: AXWebArea
    7070AXChildren: 0
    … …  
    8383AXRequired: 0
    8484AXChecked: 0
    85 AXPlatformAttributes: computed-role:group, toolkit:WebKitEfl
     85AXPlatformAttributes: toolkit:WebKitEfl
    8686------------
    8787

  • trunk/LayoutTests/platform/efl/accessibility/media-element-expected.txt

    r178705 r194015  
    2727
    2828                description: AXDescription:
    29                 role: AXRole: AXGroup
     29                role: AXRole: AXSection
    3030
    3131
    … …  
    3939
    4040                description: AXDescription:
    41                 role: AXRole: AXGroup
     41                role: AXRole: AXSection
    4242
    4343

  • trunk/Source/WebCore/ChangeLog

    r194010 r194015  
     12015-12-13  Joanmarie Diggs  <jdiggs@igalia.com>
     2
     3        AX: [EFL] Anonymous render block flow elements should be exposed as ATK_ROLE_SECTION; not ATK_ROLE_PANEL
     4        https://bugs.webkit.org/show_bug.cgi?id=152079
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Map the element to WebCore AccessibilityRole DivRole for EFL. As with GTK, this
     9        is being done in the shared layer rather than in the platform layer because we
     10        want all subsequent logic to treat anonymous render block flow elements as divs.
     11
     12        No new tests. We already have sufficient test coverage. The expectations
     13        been updated accordingly.
     14
     15        * accessibility/AccessibilityRenderObject.cpp:
     16        (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
     17
    1182015-12-12  Brady Eidson  <beidson@apple.com>
    219

  • trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

    r193841 r194015  
    27052705
    27062706    if (m_renderer->isRenderBlockFlow()) {
    2707 #if PLATFORM(GTK)
     2707#if PLATFORM(GTK) || PLATFORM(EFL)
    27082708        // For ATK, GroupRole maps to ATK_ROLE_PANEL. Panels are most commonly found (and hence
    27092709        // expected) in UI elements; not text blocks.
Note: See TracChangeset for help on using the changeset viewer.