Changeset 194047 in webkit

Timestamp:

Dec 14, 2015 11:58:14 AM (8 years ago)

Author:

timothy_horton@apple.com

Message:

Remove some Mavericks guards in ServicesOverlayController
​https://bugs.webkit.org/show_bug.cgi?id=152238

Reviewed by Darin Adler.

• page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::selectionRectsDidChange): Deleted.
(WebCore::ServicesOverlayController::selectedTelephoneNumberRangesChanged): Deleted.
The whole file is already PLATFORM(MAC) guarded, and the 10.9 guards
are no longer necessary.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/mac/ServicesOverlayController.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-12-14  Tim Horton  <timothy_horton@apple.com>
+
+        Remove some Mavericks guards in ServicesOverlayController
+        https://bugs.webkit.org/show_bug.cgi?id=152238
+
+        Reviewed by Darin Adler.
+
+        * page/mac/ServicesOverlayController.mm:
+        (WebCore::ServicesOverlayController::selectionRectsDidChange): Deleted.
+        (WebCore::ServicesOverlayController::selectedTelephoneNumberRangesChanged): Deleted.
+        The whole file is already PLATFORM(MAC) guarded, and the 10.9 guards
+        are no longer necessary.
+
 2015-12-14  Daniel Bates  <dabates@apple.com>
 

trunk/Source/WebCore/page/mac/ServicesOverlayController.mm

@@ -367 +367 @@
 void ServicesOverlayController::selectionRectsDidChange(const Vector<LayoutRect>& rects, const Vector<GapRects>& gapRects, bool isTextOnly)
 {
-#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED > 1090
     m_currentSelectionRects = rects;
     m_isTextOnly = isTextOnly;
@@ -380 +379 @@
     LOG(Services, "ServicesOverlayController - Selection rects changed - Now have %lu\n", rects.size());
     invalidateHighlightsOfType(Highlight::SelectionType);
-#else
-    UNUSED_PARAM(rects);
-    UNUSED_PARAM(gapRects);
-    UNUSED_PARAM(isTextOnly);
-#endif
 }
 
 void ServicesOverlayController::selectedTelephoneNumberRangesChanged()
 {
-#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED > 1090
     LOG(Services, "ServicesOverlayController - Telephone number ranges changed\n");
     invalidateHighlightsOfType(Highlight::TelephoneNumberType);
-#endif
 }