Changeset 194145 in webkit
- Timestamp:
- Dec 16, 2015 9:32:47 AM (8 years ago)
- Location:
- trunk/Websites/perf.webkit.org
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Websites/perf.webkit.org/ChangeLog
r194133 r194145 1 2015-12-16 Ryosuke Niwa <rniwa@webkit.org> 2 3 The chart status on v3 UI sometimes show wrong revision ranges 4 https://bugs.webkit.org/show_bug.cgi?id=152331 5 6 Reviewed by Chris Dumez. 7 8 The bug was caused by the status view not taking the data sampling that happens in TimeSeriesChart into account 9 when finding the previous point. Take this into account by using InteractiveTimeSeries.currentPoint(-1) which 10 finds the sampled data point immediately preceding the current point (at which the indicator is shown). 11 12 * public/v3/components/chart-status-view.js: 13 (ChartStatusView.prototype.updateStatusIfNeeded): 14 1 15 2015-12-15 Ryosuke Niwa <rniwa@webkit.org> 2 16 -
trunk/Websites/perf.webkit.org/public/v3/components/chart-status-view.js
r194130 r194145 46 46 47 47 if (this._chart instanceof InteractiveTimeSeriesChart) { 48 currentPoint = this._chart.currentPoint();49 50 48 var selection = this._chart.currentSelection(); 51 49 if (selection && this._usedSelection == selection) … … 62 60 previousPoint = data[0]; 63 61 } 64 } else if (currentPoint) 65 previousPoint = currentPoint.series.previousPoint(currentPoint); 62 } else { 63 currentPoint = this._chart.currentPoint(); 64 previousPoint = this._chart.currentPoint(-1); 65 } 66 66 } else { 67 67 var data = this._chart.sampledTimeSeriesData('current');
Note: See TracChangeset
for help on using the changeset viewer.