Changeset 194244 in webkit

Timestamp:

Dec 17, 2015 3:53:51 PM (8 years ago)

Author:

BJ Burg

Message:

Web Inspector: control whether to collect and dump protocol messages using a WebInspector.Setting
​https://bugs.webkit.org/show_bug.cgi?id=151635

Reviewed by Joseph Pecoraro.

Follow-up fix to stop double-logging everything.

• UserInterface/Protocol/LoggingProtocolTracer.js:

(WebInspector.LoggingProtocolTracer.prototype._processEntry):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Protocol/LoggingProtocolTracer.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-12-17  Brian Burg  <bburg@apple.com>
+
+        Web Inspector: control whether to collect and dump protocol messages using a WebInspector.Setting
+        https://bugs.webkit.org/show_bug.cgi?id=151635
+
+        Reviewed by Joseph Pecoraro.
+
+        Follow-up fix to stop double-logging everything.
+
+        * UserInterface/Protocol/LoggingProtocolTracer.js:
+        (WebInspector.LoggingProtocolTracer.prototype._processEntry):
+
 2015-12-17  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Protocol/LoggingProtocolTracer.js

@@ -119 +119 @@
             else if (entry.timings.dispatch)
                 this._logToConsole(`time-stats: Handling: ${entry.timings.dispatch || NaN}ms`);
-        } else if (this._dumpMessagesToConsole)
+        } else if (this._dumpMessagesToConsole && !entry.timings)
             this._logToConsole(`${entry.type}: ${entry.message}`);
     }