Changeset 19433 in webkit

Timestamp:

Feb 6, 2007 9:17:24 AM (17 years ago)

Author:

brmorris

Message:

w3liu, Reviewed by Yongjun Zhang <​yongjun.zhang@nokia.com>

DESC: Should check meta for charset if meta exists EHSN-6UQ6CM
​http://bugs.webkit.org/show_bug.cgi?id=12225

Location:

S60/branches/3.1m/WebCore

Files:

• ChangeLog (modified) (1 diff)
• khtml/misc/decoder.cpp (modified) (4 diffs)

S60/branches/3.1m/WebCore/ChangeLog

@@ +1 @@
+w3liu,  Reviewed by Yongjun Zhang <yongjun.zhang@nokia.com>
+        DESC: Should check meta for charset if meta exists EHSN-6UQ6CM
+        http://bugs.webkit.org/show_bug.cgi?id=12225
+
+        WARNING: NO TEST CASES ADDED OR CHANGED
+
+        * khtml/misc/decoder.cpp:
+        (Decoder::decode):
+
 yongjzha, Reviewed by Zalan.
 

S60/branches/3.1m/WebCore/khtml/misc/decoder.cpp

@@ -485 +485 @@
             const char *pEnd = buffer.length();
 #endif
+#if NOKIA_CHANGES
+            bool hasMeta = buffer.find("<meta", 0, false);
+            bool reachMeta = false;
+#endif
             while(ptr != pEnd)
             {
@@ -533 +537 @@
                     switch( id ) {
                     case ID_META:
-                    {
+                        {
+#if NOKIA_CHANGES
+                        reachMeta = true;                        
+#endif
                         // found a meta tag...
                         //ptr += 5;
@@ -544 +551 @@
                         //if( (pos = str.find("http-equiv", pos)) == -1) break;
                         //if( (pos = str.find("content-type", pos)) == -1) break;
-            while( pos < ( int ) str.length() ) {
-                if( (pos = str.find("charset", pos, false)) == -1) break;
-                pos += 7;
+                        while( pos < ( int ) str.length() ) {
+                            if( (pos = str.find("charset", pos, false)) == -1) break;
+                            pos += 7;
                             // skip whitespace..
-                while(  pos < (int)str.length() && str[pos] <= ' ' ) pos++;
+                            while(  pos < (int)str.length() && str[pos] <= ' ' ) pos++;
                             if ( pos == ( int )str.length()) break;
                             if ( str[pos++] != '=' ) continue;
                             while ( pos < ( int )str.length() &&
-                                    ( str[pos] <= ' ' ) || str[pos] == '=' || str[pos] == '"' || str[pos] == '\'')
-                pos++;
-
+                                ( str[pos] <= ' ' ) || str[pos] == '=' || str[pos] == '"' || str[pos] == '\'')
+                                pos++;
+                            
                             // end ?
                             if ( pos == ( int )str.length() ) break;
-                uint endpos = pos;
-                while( endpos < str.length() &&
-                                   (str[endpos] != ' ' && str[endpos] != '"' && str[endpos] != '\''
-                                    && str[endpos] != ';' && str[endpos] != '>') )
-                endpos++;
-#ifdef DECODE_DEBUG
-                kdDebug( 6005 ) << "Decoder: found charset: " << str.mid(pos, endpos-pos) << endl;
-#endif
-                setEncoding(str.mid(pos, endpos-pos), EncodingFromMetaTag);
-                if( m_type == EncodingFromMetaTag ) goto found;
-
+                            uint endpos = pos;
+                            while( endpos < str.length() &&
+                                (str[endpos] != ' ' && str[endpos] != '"' && str[endpos] != '\''
+                                && str[endpos] != ';' && str[endpos] != '>') )
+                                endpos++;
+#ifdef DECODE_DEBUG
+                            kdDebug( 6005 ) << "Decoder: found charset: " << str.mid(pos, endpos-pos) << endl;
+#endif
+                            setEncoding(str.mid(pos, endpos-pos), EncodingFromMetaTag);
+                            if( m_type == EncodingFromMetaTag ) goto found;
+                            
                             if ( endpos >= str.length() || str[endpos] == '/' || str[endpos] == '>' ) break;
-
-                pos = endpos + 1;
-            }
-            }
+                            
+                            pos = endpos + 1;
+                            }
+                        }
                     case (ID_META+ID_CLOSE_TAG):
                     case ID_SCRIPT:
@@ -597 +604 @@
                         break;
                     default:
+#if NOKIA_CHANGES
+                        if (hasMeta && !reachMeta)
+                            break;
+#endif
                         body = true;
 #ifdef DECODE_DEBUG