Changeset 194780 in webkit


Ignore:
Timestamp:
Jan 8, 2016 1:01:26 PM (8 years ago)
Author:
Brent Fulgham
Message:

[ANGLE] Correct UNREACHABLE runtime assertion for void constructors
https://bugs.webkit.org/show_bug.cgi?id=152900
<rdar://problem/24107501>

Reviewed by Alex Christensen.

Tested by Khronos WebGL 1.0.4 suite.

Merge a small part of ANGLE upstream commit r284735:

commit 01971113492d9aca386f2bca021b1f4b134fc277
author Dmitry Skiba <dskiba@google.com> Fri Jul 10 18:54:00 2015
committer Jamie Madill <jmadill@chromium.org> Fri Jul 10 19:03:34 2015
tree 47e42eac00f7d64cddb14b3cc21a4e605c189d20

This issue was found by <https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/bugs/angle-constructor-invalid-parameters.html?webglVersion=1&quiet=0>

  • src/compiler/translator/Types.cpp:

(TType::buildMangledName): Don't assert with UNREACHABLE here.

Location:
trunk/Source/ThirdParty/ANGLE
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/ThirdParty/ANGLE/ChangeLog

    r194430 r194780  
     12016-01-08  Brent Fulgham  <bfulgham@apple.com>
     2
     3        [ANGLE] Correct UNREACHABLE runtime assertion for void constructors
     4        https://bugs.webkit.org/show_bug.cgi?id=152900
     5        <rdar://problem/24107501>
     6
     7        Reviewed by Alex Christensen.
     8
     9        Tested by Khronos WebGL 1.0.4 suite.
     10
     11        Merge a small part of ANGLE upstream commit r284735:
     12       
     13            commit    01971113492d9aca386f2bca021b1f4b134fc277
     14            author    Dmitry Skiba <dskiba@google.com>  Fri Jul 10 18:54:00 2015
     15            committer Jamie Madill <jmadill@chromium.org>  Fri Jul 10 19:03:34 2015
     16            tree      47e42eac00f7d64cddb14b3cc21a4e605c189d20
     17
     18        This issue was found by <https://www.khronos.org/registry/webgl/sdk/tests/conformance/glsl/bugs/angle-constructor-invalid-parameters.html?webglVersion=1&quiet=0>
     19
     20        * src/compiler/translator/Types.cpp:
     21        (TType::buildMangledName): Don't assert with UNREACHABLE here.
     22
    1232015-12-28  Joonghun Park  <jh718.park@samsung.com>
    224
  • trunk/Source/ThirdParty/ANGLE/src/compiler/translator/Types.cpp

    r186169 r194780  
    143143        break;
    144144      default:
    145         UNREACHABLE();
     145        // EbtVoid, EbtAddress and non types
     146        break;
    146147    }
    147148
Note: See TracChangeset for help on using the changeset viewer.