Changeset 194879 in webkit

Timestamp:

Jan 11, 2016 5:40:24 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Storage tab navigation bar should fit on a single line
​https://bugs.webkit.org/show_bug.cgi?id=152473

Patch by Devin Rousso <Devin Rousso> on 2016-01-11
Reviewed by Timothy Hatcher.

The wrapping of the navigation bar on the Storage tab was caused by the
fact that Sidebar.js used a minimum width of 200px, regardless of the
content within the sidebar (unless it had a NavigationBar). Logic has
been added that causes the sidebar to use the selected panel's own
minimum width calculation if it is greater than 200px.

• UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype.get minimumWidth):

• UserInterface/Views/MultipleScopeBarItem.js:

(WebInspector.MultipleScopeBarItem.prototype.set selectedScopeBarItem):
(WebInspector.MultipleScopeBarItem.prototype.displaySelectedItem):
Sets the displayed text to the currently selected item.

(WebInspector.MultipleScopeBarItem.prototype.displayWidestItem):
Sets the displayed text to the widest (pixel wise) item in the select element.

• UserInterface/Views/NavigationBar.js:

(WebInspector.NavigationBar.prototype._calculateMinimumWidth):
Now uses NavigationItem.prototype.get minimumWidth.

• UserInterface/Views/NavitationItem.js:

(WebInspector.NavitationItem.prototype.get minimumWidth):
Returns the element's realOffsetWidth.

• UserInterface/Views/NetworkSidebarPanel.js:

(WebInspector.NetworkSidebarPanel.prototype.get minimumWidth):

• UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype.get minimumWidth):

• UserInterface/Views/ScopeBar.js:

(WebInspector.ScopeBar):
(WebInspector.ScopeBar.prototype.get minimumWidth):

• UserInterface/Views/Sidebar.js:

(WebInspector.Sidebar.prototype.set selectedSidebarPanel):
(WebInspector.Sidebar.prototype.get minimumWidth):
(WebInspector.Sidebar.prototype.set width):
(WebInspector.Sidebar.prototype.set collapsed):
(WebInspector.Sidebar.prototype._recalculateWidth):
Whenever the sidebar changes (e.g. tab change, sidebar becomes
visible/hidden, etc.), a width recalculation is necessary to ensure
that the navigation bar never wraps.

• UserInterface/Views/SidebarPanel.js:

(WebInspector.SidebarPanel.prototype.get minimumWidth):

• UserInterface/Views/StorageSidebarPanel.js:

(WebInspector.StorageSidebarPanel.prototype.get minimumWidth):

• UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel.prototype.get minimumWidth):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/DebuggerSidebarPanel.js (modified) (1 diff)
• UserInterface/Views/MultipleScopeBarItem.js (modified) (2 diffs)
• UserInterface/Views/NavigationBar.js (modified) (1 diff)
• UserInterface/Views/NavigationItem.js (modified) (1 diff)
• UserInterface/Views/NetworkSidebarPanel.js (modified) (1 diff)
• UserInterface/Views/ResourceSidebarPanel.js (modified) (1 diff)
• UserInterface/Views/ScopeBar.js (modified) (1 diff)
• UserInterface/Views/Sidebar.js (modified) (5 diffs)
• UserInterface/Views/SidebarPanel.js (modified) (1 diff)
• UserInterface/Views/StorageSidebarPanel.js (modified) (1 diff)
• UserInterface/Views/TimelineSidebarPanel.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-01-11  Devin Rousso  <dcrousso+webkit@gmail.com>
+
+        Web Inspector: Storage tab navigation bar should fit on a single line
+        https://bugs.webkit.org/show_bug.cgi?id=152473
+
+        Reviewed by Timothy Hatcher.
+
+        The wrapping of the navigation bar on the Storage tab was caused by the
+        fact that Sidebar.js used a minimum width of 200px, regardless of the
+        content within the sidebar (unless it had a NavigationBar). Logic has
+        been added that causes the sidebar to use the selected panel's own
+        minimum width calculation if it is greater than 200px.
+
+        * UserInterface/Views/DebuggerSidebarPanel.js:
+        (WebInspector.DebuggerSidebarPanel.prototype.get minimumWidth):
+
+        * UserInterface/Views/MultipleScopeBarItem.js:
+        (WebInspector.MultipleScopeBarItem.prototype.set selectedScopeBarItem):
+        (WebInspector.MultipleScopeBarItem.prototype.displaySelectedItem):
+        Sets the displayed text to the currently selected item.
+
+        (WebInspector.MultipleScopeBarItem.prototype.displayWidestItem):
+        Sets the displayed text to the widest (pixel wise) item in the select element.
+
+        * UserInterface/Views/NavigationBar.js:
+        (WebInspector.NavigationBar.prototype._calculateMinimumWidth):
+        Now uses NavigationItem.prototype.get minimumWidth.
+
+        * UserInterface/Views/NavitationItem.js:
+        (WebInspector.NavitationItem.prototype.get minimumWidth):
+        Returns the element's realOffsetWidth.
+
+        * UserInterface/Views/NetworkSidebarPanel.js:
+        (WebInspector.NetworkSidebarPanel.prototype.get minimumWidth):
+
+        * UserInterface/Views/ResourceSidebarPanel.js:
+        (WebInspector.ResourceSidebarPanel.prototype.get minimumWidth):
+
+        * UserInterface/Views/ScopeBar.js:
+        (WebInspector.ScopeBar):
+        (WebInspector.ScopeBar.prototype.get minimumWidth):
+
+        * UserInterface/Views/Sidebar.js:
+        (WebInspector.Sidebar.prototype.set selectedSidebarPanel):
+        (WebInspector.Sidebar.prototype.get minimumWidth):
+        (WebInspector.Sidebar.prototype.set width):
+        (WebInspector.Sidebar.prototype.set collapsed):
+        (WebInspector.Sidebar.prototype._recalculateWidth):
+        Whenever the sidebar changes (e.g. tab change, sidebar becomes
+        visible/hidden, etc.), a width recalculation is necessary to ensure
+        that the navigation bar never wraps.
+
+        * UserInterface/Views/SidebarPanel.js:
+        (WebInspector.SidebarPanel.prototype.get minimumWidth):
+
+        * UserInterface/Views/StorageSidebarPanel.js:
+        (WebInspector.StorageSidebarPanel.prototype.get minimumWidth):
+
+        * UserInterface/Views/TimelineSidebarPanel.js:
+        (WebInspector.TimelineSidebarPanel.prototype.get minimumWidth):
+
 2016-01-11  Devin Rousso  <dcrousso+webkit@gmail.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js

@@ -165 +165 @@
     // Public
 
+    get minimumWidth()
+    {
+        return this._navigationBar.minimumWidth;
+    }
+
     closed()
     {

trunk/Source/WebInspectorUI/UserInterface/Views/MultipleScopeBarItem.js

@@ -134 +134 @@
 
         if (this._selectedScopeBarItem) {
-            this._titleElement.textContent = this._selectedScopeBarItem.label;
+            this.displaySelectedItem();
             this._selectedScopeBarItem.selected = true;
         }
@@ -142 +142 @@
 
         this._ignoreItemSelectedEvent = false;
+    }
+
+    displaySelectedItem()
+    {
+        this._titleElement.textContent = this._selectedScopeBarItem.label;
+    }
+
+    displayWidestItem()
+    {
+        let widestLabel = null;
+        let widestSize = 0;
+        for (let option of Array.from(this._selectElement.options)) {
+            this._titleElement.textContent = option.label;
+            if (this._titleElement.realOffsetWidth > widestSize) {
+                widestSize = this._titleElement.realOffsetWidth;
+                widestLabel = option.label;
+            }
+        }
+        this._titleElement.textContent = widestLabel;
     }
 

trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.js

@@ -362 +362 @@
             this.element.classList.add(WebInspector.NavigationBar.CollapsedStyleClassName);
 
-        var totalItemWidth = 0;
-        for (var i = 0; i < this._navigationItems.length; ++i) {
+        let totalItemWidth = 0;
+        for (let item of this._navigationItems) {
             // Skip flexible space items since they can take up no space at the minimum width.
-            if (this._navigationItems[i] instanceof WebInspector.FlexibleSpaceNavigationItem)
+            if (item instanceof WebInspector.FlexibleSpaceNavigationItem)
                 continue;
-            totalItemWidth += this._navigationItems[i].element.realOffsetWidth;
+
+            totalItemWidth += item.minimumWidth;
         }
 

trunk/Source/WebInspectorUI/UserInterface/Views/NavigationItem.js

@@ -61 +61 @@
     }
 
+    get minimumWidth()
+    {
+        return this._element.realOffsetWidth;
+    }
+
     updateLayout(expandOnly)
     {

trunk/Source/WebInspectorUI/UserInterface/Views/NetworkSidebarPanel.js

@@ -72 +72 @@
     // Public
 
+    get minimumWidth()
+    {
+        return this._navigationBar.minimumWidth;
+    }
+
     closed()
     {

trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js

@@ -76 +76 @@
     // Public
 
+    get minimumWidth()
+    {
+        return this._navigationBar.minimumWidth;
+    }
+
     closed()
     {

trunk/Source/WebInspectorUI/UserInterface/Views/ScopeBar.js

@@ -36 +36 @@
         this._shouldGroupNonExclusiveItems = shouldGroupNonExclusiveItems || false;
 
+        this._minimumWidth = 0;
+
         this._populate();
     }
 
     // Public
+
+    get minimumWidth()
+    {
+        if (!this._minimumWidth) {
+            // If a "display: flex;" element is too small for its contents and
+            // has "flex-wrap: wrap;" set as well, this will cause the contents
+            // to wrap (potentially overflowing), thus preventing a proper
+            // measurement of the width of the element. Removing the "flex-wrap"
+            // property will ensure that the contents are rendered on one line.
+            this.element.style.flexWrap = "initial !important";
+
+            if (this._multipleItem)
+                this._multipleItem.displayWidestItem();
+
+            this._minimumWidth = this.element.realOffsetWidth;
+            this.element.style.flexWrap = null;
+
+            if (this._multipleItem)
+                this._multipleItem.displaySelectedItem();
+        }
+        return this._minimumWidth;
+    }
 
     get defaultItem()

trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js

@@ -148 +148 @@
                 this._selectedSidebarPanel.shown();
                 this._selectedSidebarPanel.visibilityDidChange();
+                this._recalculateWidth();
             }
         }
@@ -158 +159 @@
         if (this._navigationBar)
             return Math.max(WebInspector.Sidebar.AbsoluteMinimumWidth, this._navigationBar.minimumWidth);
+        if (this._selectedSidebarPanel)
+            return Math.max(WebInspector.Sidebar.AbsoluteMinimumWidth, this._selectedSidebarPanel.minimumWidth);
         return WebInspector.Sidebar.AbsoluteMinimumWidth;
     }
@@ -178 +181 @@
             return;
 
-        newWidth = Math.max(this.minimumWidth, Math.min(newWidth, this.maximumWidth));
-
-        this.element.style.width = newWidth + "px";
-
-        if (!this.collapsed && this._navigationBar)
-            this._navigationBar.needsLayout();
-
-        if (!this.collapsed && this._selectedSidebarPanel)
-            this._selectedSidebarPanel.widthDidChange();
-
-        this.dispatchEventToListeners(WebInspector.Sidebar.Event.WidthDidChange);
+        this._recalculateWidth(newWidth);
     }
 
@@ -214 +207 @@
 
             this._selectedSidebarPanel.visibilityDidChange();
-
             this._selectedSidebarPanel.widthDidChange();
+            this._recalculateWidth();
         }
 
@@ -272 +265 @@
     // Private
 
+    _recalculateWidth(newWidth = this.width)
+    {
+        // Need to add 1 because of the 1px border-right.
+        newWidth = Number.constrain(newWidth, this.minimumWidth + 1, this.maximumWidth);
+        this.element.style.width = Math.ceil(newWidth) + "px";
+
+        if (!this.collapsed && this._navigationBar)
+            this._navigationBar.needsLayout();
+
+        if (!this.collapsed && this._selectedSidebarPanel)
+            this._selectedSidebarPanel.widthDidChange();
+
+        this.dispatchEventToListeners(WebInspector.Sidebar.Event.WidthDidChange);
+    }
+
     _navigationItemSelected(event)
     {

trunk/Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js

@@ -82 +82 @@
     }
 
+    get minimumWidth()
+    {
+        // Implemented by subclasses.
+        return 0;
+    }
+
     show()
     {

trunk/Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js

@@ -107 +107 @@
     // Public
 
+    get minimumWidth()
+    {
+        return this._navigationBar.minimumWidth;
+    }
+
     showDefaultContentView()
     {

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineSidebarPanel.js

@@ -219 +219 @@
     // Public
 
+    get minimumWidth()
+    {
+        if (this._viewModeNavigationBar)
+            return Math.max(this._replayNavigationBar.minimumWidth, this._viewModeNavigationBar.minimumWidth);
+        return this._replayNavigationBar.minimumWidth;
+    }
+
     shown()
     {