Changeset 19499 in webkit

Timestamp:

Feb 8, 2007 10:28:20 AM (17 years ago)

Author:

brmorris

Message:

yaharon, reviewed by yongjun.

DESC: [S60] Daily BAT 3.2: S60NG_Login- Password field is not filled automatically KDEA-6XZEDY
​http://bugs.webkit.org/show_bug.cgi?id=12696

Location:

S60/branches/3.1m/WebKit

Files:

• BrowserView/inc/WebKitLoader.h (modified) (2 diffs)
• BrowserView/src/WebKitLoader.cpp (modified) (2 diffs)
• BrowserView/src/webkitbridge.cpp (modified) (1 diff)
• ChangeLog (modified) (1 diff)

S60/branches/3.1m/WebKit/BrowserView/inc/WebKitLoader.h

@@ -281 +281 @@
         HBufC* PageUrl() { return iPageUrl; }
 
+        /**
+        * PageUrl
+        *
+        * @since 3.1
+        * @param
+        * @return
+        */
+        HBufC* PrevPageUrl() { return iPrevPageUrl; }
+        
     /**
         * IsUrlInCache
@@ -472 +481 @@
         //
         HBufC*                  iPageUrl;              // owned
+        //
+        HBufC*                  iPrevPageUrl;              // owned
     //
     CWmlDispatcher*     iWmlContentListener;    //owned

S60/branches/3.1m/WebKit/BrowserView/src/WebKitLoader.cpp

@@ -197 +197 @@
     delete iPageUrl;
     //
+    delete iPrevPageUrl;
+    //
     delete iTransactionList;
     //
@@ -812 +814 @@
     const TDesC& aResponseUrl )
     {
-    delete iPageUrl;
+    delete iPrevPageUrl;
+    iPrevPageUrl = iPageUrl;
     iPageUrl = aResponseUrl.AllocL();
     }

S60/branches/3.1m/WebKit/BrowserView/src/webkitbridge.cpp

@@ -722 +722 @@
         if (formManager)
             {
-            formManager->SaveDataL(RequestedURLString(),aFormValues);
+            // closeURL is now called when receiving the response headers, not when submitting the form
+            __ASSERT_DEBUG( iLoader->PrevPageUrl(), User::Panic( _L("WebKitLoader"), KErrGeneral ) );
+            TPtrC url(iLoader->PrevPageUrl()->Des());
+            formManager->SaveDataL(url,aFormValues);
             } 
         );

S60/branches/3.1m/WebKit/ChangeLog

@@ +1 @@
+yaharon, reviewed by yongjun.
+        DESC: [S60] Daily BAT 3.2: S60NG_Login- Password field is not filled automatically KDEA-6XZEDY
+        http://bugs.webkit.org/show_bug.cgi?id=12696
+
+        * BrowserView/inc/WebKitLoader.h:
+        (CWebKitLoader::PrevPageUrl):
+        * BrowserView/src/WebKitLoader.cpp:
+        (CWebKitLoader::~CWebKitLoader):
+        (CWebKitLoader::SetPageUrlL):
+        * BrowserView/src/webkitbridge.cpp:
+        (CWebKitBridge::SaveFormData):
+
 bujtas, reviewed by yngjun.
         DESC: Highlighting lost when browser toolbar is dismissed TMCN-6XWLEC