Changeset 195011 in webkit

Timestamp:

Jan 14, 2016 12:50:23 AM (8 years ago)

Author:

peavo@outlook.com

Message:

[Win] Remove workarounds for fixed bugs in fmod and pow.
​https://bugs.webkit.org/show_bug.cgi?id=153071

Reviewed by Brent Fulgham.

Source/WebCore:

Compile fix, help MSVC pick correct pow overload.

• rendering/shapes/BoxShape.cpp:

(WebCore::adjustRadiusForMarginBoxShape):

Source/WTF:

The bugs have been fixed in the MSVC CRT, and we can remove the workarounds.

• wtf/MathExtras.h:

(wtf_fmod): Deleted.
(wtf_pow): Deleted.

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/MathExtras.h (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/shapes/BoxShape.cpp (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2016-01-14  Per Arne Vollan  <peavo@outlook.com>
+
+        [Win] Remove workarounds for fixed bugs in fmod and pow.
+        https://bugs.webkit.org/show_bug.cgi?id=153071
+
+        Reviewed by Brent Fulgham.
+
+        The bugs have been fixed in the MSVC CRT, and we can remove the workarounds.
+
+        * wtf/MathExtras.h:
+        (wtf_fmod): Deleted.
+        (wtf_pow): Deleted.
+
 2016-01-13  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WTF/wtf/MathExtras.h

@@ -119 +119 @@
 }
 
-// Work around a bug in the Microsoft CRT, where fmod(x, +-infinity) yields NaN instead of x.
-extern "C" inline double wtf_fmod(double x, double y) { return (!std::isinf(x) && std::isinf(y)) ? x : fmod(x, y); }
-
-// Work around a bug in the Microsoft CRT, where pow(NaN, 0) yields NaN instead of 1.
-extern "C" inline double wtf_pow(double x, double y) { return y == 0 ? 1 : pow(x, y); }
-
 #define atan2(x, y) wtf_atan2(x, y)
-#define fmod(x, y) wtf_fmod(x, y)
-#define pow(x, y) wtf_pow(x, y)
 
 #endif // COMPILER(MSVC)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-01-14  Per Arne Vollan  <peavo@outlook.com>
+
+        [Win] Remove workarounds for fixed bugs in fmod and pow.
+        https://bugs.webkit.org/show_bug.cgi?id=153071
+
+        Reviewed by Brent Fulgham.
+
+        Compile fix, help MSVC pick correct pow overload.
+
+        * rendering/shapes/BoxShape.cpp:
+        (WebCore::adjustRadiusForMarginBoxShape):
+
 2016-01-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
 

trunk/Source/WebCore/rendering/shapes/BoxShape.cpp

@@ -44 +44 @@
     LayoutUnit ratio = radius / margin;
     if (ratio < 1)
-        return radius + (margin * (1 + pow(ratio - 1, 3)));
+        return radius + (margin * (1 + pow(ratio - 1, 3.0)));
 
     return radius + margin;