Changeset 195160 in webkit


Ignore:
Timestamp:
Jan 15, 2016 5:03:47 PM (8 years ago)
Author:
Chris Dumez
Message:

Drop obsolete HTMLDocument.width / height attributes
​https://bugs.webkit.org/show_bug.cgi?id=153144

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

  • web-platform-tests/dom/historical-expected.txt:

Source/WebCore:

Drop obsolete HTMLDocument.width / height attributes as these are
obsolete and already not supported by other major browsers (tested
Firefox and Chrome).

No new tests, already covered by existing tests.

  • html/HTMLDocument.idl:

LayoutTests:

  • fast/dom/HTMLDocument/width-and-height-expected.txt: Removed.
  • fast/dom/HTMLDocument/width-and-height.html: Removed.

Drop outdated test.

  • fast/dom/Window/window-property-invalid-characters-ignored-expected.txt:
  • fast/dom/Window/window-property-invalid-characters-ignored.html:

Stop relying on Document.width / height as these are obsolete.

Location:
trunk
Files:
2 deleted
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r195158 r195160  
     12016-01-15  Chris Dumez  <cdumez@apple.com>
     2
     3        Drop obsolete HTMLDocument.width / height attributes
     4        https://bugs.webkit.org/show_bug.cgi?id=153144
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        * fast/dom/HTMLDocument/width-and-height-expected.txt: Removed.
     9        * fast/dom/HTMLDocument/width-and-height.html: Removed.
     10        Drop outdated test.
     11
     12        * fast/dom/Window/window-property-invalid-characters-ignored-expected.txt:
     13        * fast/dom/Window/window-property-invalid-characters-ignored.html:
     14        Stop relying on Document.width / height as these are obsolete.
     15
    1162016-01-15  Beth Dakin  <bdakin@apple.com>
    217

  • trunk/LayoutTests/fast/dom/Window/window-property-invalid-characters-ignored-expected.txt

    r169849 r195160  
    44
    55
    6 PASS w.document.width is 123
    7 PASS w.document.height is 123
     6PASS w.innerWidth is 123
     7PASS w.innerHeight is 123
    88PASS w !== window is true
    99PASS successfullyParsed is true

  • trunk/LayoutTests/fast/dom/Window/window-property-invalid-characters-ignored.html

    r169849 r195160  
    1717function finishTest()
    1818{
    19     shouldBe("w.document.width", "123");
    20     shouldBe("w.document.height", "123");
     19    shouldBe("w.innerWidth", "123");
     20    shouldBe("w.innerHeight", "123");
    2121    shouldBeTrue("w !== window");
    2222    w.close();

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r195157 r195160  
     12016-01-15  Chris Dumez  <cdumez@apple.com>
     2
     3        Drop obsolete HTMLDocument.width / height attributes
     4        https://bugs.webkit.org/show_bug.cgi?id=153144
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Rebaseline W3C test now that more checks are passing.
     9
     10        * web-platform-tests/dom/historical-expected.txt:
     11
    1122016-01-15  Chris Dumez  <cdumez@apple.com>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt

    r195157 r195160  
    2929PASS Historical DOM features must be removed: renameNode
    3030FAIL Historical DOM features must be removed: defaultCharset assert_equals: expected (undefined) undefined but got (string) "ISO-8859-1"
    31 FAIL Historical DOM features must be removed: height assert_equals: expected (undefined) undefined but got (number) 600
    32 FAIL Historical DOM features must be removed: width assert_equals: expected (undefined) undefined but got (number) 800
     31PASS Historical DOM features must be removed: height
     32PASS Historical DOM features must be removed: width
    3333PASS DOMImplementation.getFeature() must be nuked.
    3434PASS Historical DOM features must be removed: schemaTypeInfo

  • trunk/Source/WebCore/ChangeLog

    r195157 r195160  
     12016-01-15  Chris Dumez  <cdumez@apple.com>
     2
     3        Drop obsolete HTMLDocument.width / height attributes
     4        https://bugs.webkit.org/show_bug.cgi?id=153144
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Drop obsolete HTMLDocument.width / height attributes as these are
     9        obsolete and already not supported by other major browsers (tested
     10        Firefox and Chrome).
     11
     12        No new tests, already covered by existing tests.
     13
     14        * html/HTMLDocument.idl:
     15
    1162016-01-15  Chris Dumez  <cdumez@apple.com>
    217

  • trunk/Source/WebCore/html/HTMLDocument.idl

    r188590 r195160  
    4646    void releaseEvents();
    4747
     48#if !defined(LANGUAGE_JAVASCRIPT) || !LANGUAGE_JAVASCRIPT
    4849    readonly attribute long width;
    4950    readonly attribute long height;
     51#endif
     52
    5053             [TreatNullAs=NullString] attribute DOMString dir;
    5154             [TreatNullAs=NullString] attribute DOMString designMode;
Note: See TracChangeset for help on using the changeset viewer.