Changeset 195167 in webkit
- Timestamp:
- Jan 16, 2016 1:44:17 AM (8 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r195165 r195167 1 2016-01-16 Carlos Garcia Campos <cgarcia@igalia.com> 2 3 [GTK] List box selections stopped working again with GTK+ from current git master 4 https://bugs.webkit.org/show_bug.cgi?id=153122 5 6 Reviewed by Michael Catanzaro. 7 8 The problem is that the ListBox selection implementation is 9 wrong. We are using a similar implementation to GtkEntry, but 10 GtkTreeView doesn't have a child CSS node for selections. 11 12 * rendering/RenderThemeGtk.cpp: 13 (WebCore::styleColor): Don't use a child style context for ListBox selections. 14 (WebCore::createStyleContext): Remove ListBoxSelection. 15 1 16 2016-01-14 Carlos Garcia Campos <cgarcia@igalia.com> 2 17 -
trunk/Source/WebCore/rendering/RenderThemeGtk.cpp
r195153 r195167 159 159 ProgressBarProgress, 160 160 ListBox, 161 ListBoxSelection,162 161 SpinButton, 163 162 SpinButtonUpButton, … … 334 333 #endif 335 334 gtk_widget_path_iter_add_class(path.get(), -1, GTK_STYLE_CLASS_VIEW); 336 break;337 case ListBoxSelection:338 gtk_widget_path_append_type(path.get(), GTK_TYPE_TREE_VIEW);339 #if GTK_CHECK_VERSION(3, 19, 2)340 gtk_widget_path_iter_set_object_name(path.get(), -1, "selection");341 #else342 gtk_widget_path_iter_add_class(path.get(), -1, GTK_STYLE_CLASS_VIEW);343 #endif344 335 break; 345 336 case SpinButton: … … 1290 1281 GRefPtr<GtkStyleContext> parentContext; 1291 1282 RenderThemePart part = themePart; 1292 if (state & GTK_STATE_FLAG_SELECTED) { 1293 parentContext = createStyleContext(themePart); 1294 ASSERT(themePart == Entry || themePart == ListBox); 1295 part = themePart == Entry ? EntrySelection : ListBoxSelection; 1283 if (themePart == Entry && (state & GTK_STATE_FLAG_SELECTED)) { 1284 parentContext = createStyleContext(Entry); 1285 part = EntrySelection; 1296 1286 } 1297 1287
Note: See TracChangeset
for help on using the changeset viewer.