Changeset 195177 in webkit

Timestamp:

Jan 16, 2016 4:00:43 PM (8 years ago)

Author:

Michael Catanzaro

Message:

[GTK] Add a couple comments to ScrollbarThemeGtk
​https://bugs.webkit.org/show_bug.cgi?id=153184

Reviewed by Carlos Garcia Campos.

• platform/gtk/ScrollbarThemeGtk.cpp:

(WebCore::ScrollbarThemeGtk::paint):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/ScrollbarThemeGtk.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-01-16  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [GTK] Add a couple comments to ScrollbarThemeGtk
+        https://bugs.webkit.org/show_bug.cgi?id=153184
+
+        Reviewed by Carlos Garcia Campos.
+
+        * platform/gtk/ScrollbarThemeGtk.cpp:
+        (WebCore::ScrollbarThemeGtk::paint):
+
 2016-01-16  Andreas Kling  <akling@apple.com>
 

trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp

@@ -173 +173 @@
 }
 
+// The GtkStyleContext returned by this function is cached by ScrollbarThemeGtk::paint for the
+// duration of its scope, so a different GtkStyleContext with updated theme properties will be
+// used for each call to paint.
 GRefPtr<GtkStyleContext> ScrollbarThemeGtk::getOrCreateStyleContext(ScrollbarOrientation orientation)
 {
@@ -353 +356 @@
         return false;
 
+    // Cache a new GtkStyleContext for the duration of this scope.
     TemporaryChange<GRefPtr<GtkStyleContext>> tempStyleContext(m_cachedStyleContext, getOrCreateStyleContext(scrollbar.orientation()));