Changeset 19519 in webkit

Timestamp:

Feb 8, 2007 7:45:40 PM (17 years ago)

Author:

brmorris

Message:

yaharon, Reviewed by zalan

DESC: crash when selecting the left Soft key Options when the cursor is in textarea field SCHY-6Y7SHD
​http://bugs.webkit.org/show_bug.cgi?id=12706

Location:

S60/branches/3.1m/WebCore

Files:

• ChangeLog (modified) (1 diff)
• khtml/html/html_formimpl.cpp (modified) (2 diffs)
• khtml/html/html_formimpl.h (modified) (1 diff)

S60/branches/3.1m/WebCore/ChangeLog

@@ +1 @@
+yaharon, Reviewed by zalan
+        DESC: crash when selecting the left Soft key Options when the cursor is in textarea field SCHY-6Y7SHD
+        http://bugs.webkit.org/show_bug.cgi?id=12706
+
+        WARNING: NO TEST CASES ADDED OR CHANGED
+
+        * khtml/html/html_formimpl.cpp:
+        (DOM::):
+        * khtml/html/html_formimpl.h:
+
 yadavall, Reviewed by Zalan Bujtas.
         DESC: Unclosed object tag causing problem MPAK-6XC86M

S60/branches/3.1m/WebCore/khtml/html/html_formimpl.cpp

@@ -2878 +2878 @@
             return;
 
-#if NOKIA_CHANGES
-        if (m_render && static_cast<RenderWidget*>(m_render)->widget())
-            static_cast<RenderWidget*>(m_render)->widget()->activate();
-        evt->setDefaultHandled();
-#else
+#ifndef NOKIA_CHANGES
         DOMString key = static_cast<KeyboardEventImpl *>(evt)->keyIdentifier();
         
@@ -3427 +3423 @@
     m_valueMatchesRenderer = false;
 }
-#ifdef NOKIA_CHANGES
-void HTMLTextAreaElementImpl::defaultEventHandler(EventImpl *evt)
-{
-    if (evt->id() == EventImpl::KEYPRESS_EVENT && evt->isKeyboardEvent()) {
-        if (m_render && static_cast<RenderWidget*>(m_render)->widget())
-            static_cast<RenderWidget*>(m_render)->widget()->activate();
-        evt->setDefaultHandled();
-     }
-
-    HTMLGenericFormElementImpl::defaultEventHandler(evt);
-}
-#endif
 
 // -------------------------------------------------------------------------

S60/branches/3.1m/WebCore/khtml/html/html_formimpl.h

@@ -679 +679 @@
     
     virtual void accessKeyAction(bool sendToAnyElement);
-#if NOKIA_CHANGES    
-    virtual void defaultEventHandler(EventImpl *evt);
-#endif
     
 protected: