Changeset 195342 in webkit


Ignore:
Timestamp:
Jan 19, 2016 10:20:03 PM (8 years ago)
Author:
jmarcell@apple.com
Message:

Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
​https://bugs.webkit.org/show_bug.cgi?id=153262

Reviewed by Alexey Proskuryakov.

Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
such cases this revisionContentForIteration method does not have any content to return, thus the
assertion fails.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:

(BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js

    r195076 r195342  
    293293            shouldAddPlusSign = true;
    294294        }
    295         console.assert(fragment.childNodes.length);
    296295        return fragment;
    297296    },

  • trunk/Tools/ChangeLog

    r195288 r195342  
     12016-01-19  Jason Marcell  <jmarcell@apple.com>
     2
     3        Remove assertion from revisionContentForIteration that is causing errors on the dashboard.
     4        https://bugs.webkit.org/show_bug.cgi?id=153262
     5
     6        Reviewed by Alexey Proskuryakov.
     7
     8        Occasionaly some buildbot iterations will not have their "got_revisions" property populated. In
     9        such cases this revisionContentForIteration method does not have any content to return, thus the
     10        assertion fails.
     11
     12        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
     13        (BuildbotQueueView.prototype.revisionContentForIteration): Removed assertion that was causing errors.
     14
    1152016-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
    216
Note: See TracChangeset for help on using the changeset viewer.