Changeset 195344 in webkit

Timestamp:

Jan 19, 2016 10:22:19 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Uncaught exception when logging an Error object
​https://bugs.webkit.org/show_bug.cgi?id=153258
<rdar://problem/24249068>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-19
Reviewed by Timothy Hatcher.

• UserInterface/Views/ErrorObjectView.js:

(WebInspector.ErrorObjectView):
Initialize members that are used later for clarity.

(WebInspector.ErrorObjectView.prototype.collapse):
(WebInspector.ErrorObjectView.prototype.expand):
This never has a previewView, remove it.

(WebInspector.ErrorObjectView.prototype.appendTitleSuffix):
Add the suffix ("= $1") after the description and before the
content tree outline.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ErrorObjectView.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-01-19  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Uncaught exception when logging an Error object
+        https://bugs.webkit.org/show_bug.cgi?id=153258
+        <rdar://problem/24249068>
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/ErrorObjectView.js:
+        (WebInspector.ErrorObjectView):
+        Initialize members that are used later for clarity.
+
+        (WebInspector.ErrorObjectView.prototype.collapse):
+        (WebInspector.ErrorObjectView.prototype.expand):
+        This never has a previewView, remove it.
+
+        (WebInspector.ErrorObjectView.prototype.appendTitleSuffix):
+        Add the suffix ("= $1") after the description and before the
+        content tree outline.
+
 2016-01-19  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ErrorObjectView.js

@@ -33 +33 @@
 
         this._object = object;
+
+        this._expanded = false;
+        this._hasStackTrace = false;
 
         this._element = document.createElement("div");
@@ -104 +107 @@
         this._element.classList.add("expanded");
 
-        if (this._previewView)
-            this._previewView.showTitle();
-
         this.update();
     }
@@ -117 +117 @@
         this._expanded = false;
         this._element.classList.remove("expanded");
+    }
 
-        if (this._previewView)
-            this._previewView.showPreview();
+    appendTitleSuffix(suffixElement)
+    {
+        this._element.insertBefore(suffixElement, this._outlineElement);
     }