Changeset 19537 in webkit

Timestamp:

Feb 9, 2007 12:33:01 PM (17 years ago)

Author:

andersca

Message:

Reviewed by Geoff.

<rdar://problem/4816376>
REGRESSION: NetNewsWire 3.0 - Crashes in WebDocumentLoaderMac::attachToFrame() (12674)

The bug was that the NNW policy delegate never calls back on the policy listener so we'll try to do a load
while there's a policy decision underway. The extra call to setPolicyDocumentLoader would cause a detached (and deallocated)
WebDataSource to be reattached and thus causing a crash.

• loader/FrameLoader.cpp: (WebCore::FrameLoader::load): Remove extra call to setPolicyDocumentLoader.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/FrameLoader.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-02-09  Anders Carlsson  <acarlsson@apple.com>
+
+        Reviewed by Geoff.
+
+        <rdar://problem/4816376> 
+        REGRESSION: NetNewsWire 3.0 - Crashes in WebDocumentLoaderMac::attachToFrame() (12674)
+        
+        The bug was that the NNW policy delegate never calls back on the policy listener so we'll try to do a load
+        while there's a policy decision underway. The extra call to setPolicyDocumentLoader would cause a detached (and deallocated)
+        WebDataSource to be reattached and thus causing a crash.
+        
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::load):
+        Remove extra call to setPolicyDocumentLoader.
+
 2007-02-09  Beth Dakin  <bdakin@apple.com>
 

trunk/WebCore/loader/FrameLoader.cpp

@@ -1835 +1835 @@
 {
     RefPtr<DocumentLoader> loader = m_client->createDocumentLoader(request, SubstituteData());
-    setPolicyDocumentLoader(loader.get());
 
     loader->setTriggeringAction(action);