Changeset 195447 in webkit
- Timestamp:
- Jan 22, 2016 1:19:44 AM (8 years ago)
- Location:
- trunk
- Files:
-
- 2 deleted
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r195445 r195447 1 2016-01-22 ChangSeok Oh <changseok.oh@collabora.com> 2 3 [GTK] Remove a focus ring on anchor node when focused by mouse. 4 https://bugs.webkit.org/show_bug.cgi?id=136121 5 6 Reviewed by Michael Catanzaro. 7 8 Removed gtk and efl specific results for the test. 9 10 * platform/efl/fast/events/click-focus-anchor-expected.txt: Removed. 11 * platform/gtk/fast/events/click-focus-anchor-expected.txt: Removed. 12 1 13 2016-01-21 Simon Fraser <simon.fraser@apple.com> 2 14 -
trunk/Source/WebCore/ChangeLog
r195445 r195447 1 2016-01-22 ChangSeok Oh <changseok.oh@collabora.com> 2 3 [GTK] Remove a focus ring on anchor node when focused by mouse. 4 https://bugs.webkit.org/show_bug.cgi?id=136121 5 6 Reviewed by Michael Catanzaro. 7 8 Safari, Chrome and FF don't show a focus ring, the dotted rectangle on anchor node 9 for mouse clicking. I think the behavior is reasonable and looks better. 10 No reason for gtk & efl ports to keep the focus on anchor node. Of course, this change should not 11 affect the focus ring for tab navigation. 12 13 No new tests since an existing test can cover this. 14 Tests: fast/events/click-focus-anchor.html 15 16 * html/HTMLAnchorElement.cpp: 17 (WebCore::HTMLAnchorElement::isMouseFocusable): 18 1 19 2016-01-21 Simon Fraser <simon.fraser@apple.com> 2 20 -
trunk/Source/WebCore/html/HTMLAnchorElement.cpp
r194819 r195447 96 96 bool HTMLAnchorElement::isMouseFocusable() const 97 97 { 98 #if !(PLATFORM(EFL) || PLATFORM(GTK))99 98 // Only allow links with tabIndex or contentEditable to be mouse focusable. 100 // This is our rule for the Mac platform; on many other platforms we focus any link you click on.101 99 if (isLink()) 102 100 return HTMLElement::supportsFocus(); 103 #endif104 101 105 102 return HTMLElement::isMouseFocusable();
Note: See TracChangeset
for help on using the changeset viewer.