Changeset 195454 in webkit

Timestamp:

Jan 22, 2016 10:03:26 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Class toggle add icon flashes when changing nodes
​https://bugs.webkit.org/show_bug.cgi?id=153341

Patch by Devin Rousso <Devin Rousso> on 2016-01-22
Reviewed by Timothy Hatcher.

• UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WebInspector.CSSStyleDetailsSidebarPanel.prototype._populateClassToggles):
Changed the way in which the class toggles are repopulated to prevent the
add class icon from being removed and re-added.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/CSSStyleDetailsSidebarPanel.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-01-22  Devin Rousso  <dcrousso+webkit@gmail.com>
+
+        Web Inspector: Class toggle add icon flashes when changing nodes
+        https://bugs.webkit.org/show_bug.cgi?id=153341
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
+        (WebInspector.CSSStyleDetailsSidebarPanel.prototype._populateClassToggles):
+        Changed the way in which the class toggles are repopulated to prevent the
+        add class icon from being removed and re-added.
+
 2016-01-21  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js

@@ -354 +354 @@
     _populateClassToggles()
     {
-        this._classListContainer.removeChildren();
-        this._classListContainer.appendChild(this._addClassContainer);
+        // Ensure that _addClassContainer is the first child of _classListContainer.
+        while (this._classListContainer.children.length > 1)
+            this._classListContainer.children[1].remove();
 
         let classes = this.domNode.getAttribute("class");