Changeset 195456 in webkit

Timestamp:

Jan 22, 2016 10:07:58 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Sidebar's should remember their width's
​https://bugs.webkit.org/show_bug.cgi?id=153007

Patch by Devin Rousso <Devin Rousso> on 2016-01-22
Reviewed by Timothy Hatcher.

• UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WebInspector.CSSStyleDetailsSidebarPanel.prototype.widthDidChange):
Now calls superclass function.

• UserInterface/Views/Sidebar.js:

(WebInspector.Sidebar.prototype.set selectedSidebarPanel):
Now calls _recalculateWidth with the saved width value of the sidebar as
the first parameter.

(WebInspector.Sidebar.prototype.set collapsed):
Now only calls _recalculateWidth if the selected sidebar panel is visible,
seeing as if it is hidden the width is irrelevant.

• UserInterface/Views/SidebarPanel.js:

(WebInspector.SidebarPanel):
Creates a setting object using the panel's identifier to store the current width.

(WebInspector.SidebarPanel.prototype.get savedWidth):
(WebInspector.SidebarPanel.prototype.widthDidChange):
So long as the current width has a value, save it to the setting object.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/CSSStyleDetailsSidebarPanel.js (modified) (1 diff)
• UserInterface/Views/Sidebar.js (modified) (2 diffs)
• UserInterface/Views/SidebarPanel.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-01-22  Devin Rousso  <dcrousso+webkit@gmail.com>
+
+        Web Inspector: Sidebar's should remember their width's
+        https://bugs.webkit.org/show_bug.cgi?id=153007
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
+        (WebInspector.CSSStyleDetailsSidebarPanel.prototype.widthDidChange):
+        Now calls superclass function.
+
+        * UserInterface/Views/Sidebar.js:
+        (WebInspector.Sidebar.prototype.set selectedSidebarPanel):
+        Now calls _recalculateWidth with the saved width value of the sidebar as
+        the first parameter.
+
+        (WebInspector.Sidebar.prototype.set collapsed):
+        Now only calls _recalculateWidth if the selected sidebar panel is visible,
+        seeing as if it is hidden the width is irrelevant.
+
+        * UserInterface/Views/SidebarPanel.js:
+        (WebInspector.SidebarPanel):
+        Creates a setting object using the panel's identifier to store the current width.
+
+        (WebInspector.SidebarPanel.prototype.get savedWidth):
+        (WebInspector.SidebarPanel.prototype.widthDidChange):
+        So long as the current width has a value, save it to the setting object.
+
 2016-01-22  Devin Rousso  <dcrousso+webkit@gmail.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js

@@ -173 +173 @@
     widthDidChange()
     {
+        super.widthDidChange();
+
         this._updateNoForcedPseudoClassesScrollOffset();
 

trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js

@@ -148 +148 @@
                 this._selectedSidebarPanel.shown();
                 this._selectedSidebarPanel.visibilityDidChange();
-                this._recalculateWidth();
+                this._recalculateWidth(this._selectedSidebarPanel.savedWidth);
             }
         }
@@ -201 +201 @@
 
         if (this._selectedSidebarPanel) {
-            if (this._selectedSidebarPanel.visible)
+            if (this._selectedSidebarPanel.visible) {
                 this._selectedSidebarPanel.shown();
-            else
+                this._recalculateWidth(this._selectedSidebarPanel.savedWidth);
+            } else
                 this._selectedSidebarPanel.hidden();
 
             this._selectedSidebarPanel.visibilityDidChange();
-            this._selectedSidebarPanel.widthDidChange();
-            this._recalculateWidth();
         }
 

trunk/Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js

@@ -34 +34 @@
         this._selected = false;
 
+        this._widthSetting = new WebInspector.Setting(identifier + "-sidebar-panel-width", 0);
         this._savedScrollPosition = 0;
 
@@ -86 +87 @@
         // Implemented by subclasses.
         return 0;
+    }
+
+    get savedWidth()
+    {
+        return this._widthSetting.value;
     }
 
@@ -149 +155 @@
     widthDidChange()
     {
+        let width = this.element.realOffsetWidth;
+        if (width && width !== this._widthSetting.value)
+            this._widthSetting.value = width;
+
         // Implemented by subclasses.
     }