Changeset 195457 in webkit

Timestamp:

Jan 22, 2016 10:11:51 AM (8 years ago)

Author:

Chris Fleizach

Message:

AX: ARIA combo boxes are not returning the right value for selected text range
​https://bugs.webkit.org/show_bug.cgi?id=153260

Reviewed by Darin Adler.

Source/WebCore:

Just because an element has an ARIA role doesn't mean we should always use the selected text range of the whole document.
If the element is also a text based ARIA control, we can still use the element's inner text range to return the right value.

Test: accessibility/selected-text-range-aria-elements.html

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::selectedTextRange):

LayoutTests:

• accessibility/selected-text-range-aria-elements-expected.txt: Added.
• accessibility/selected-text-range-aria-elements.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/selected-text-range-aria-elements-expected.txt (added)
• LayoutTests/accessibility/selected-text-range-aria-elements.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityRenderObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-01-22  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: ARIA combo boxes are not returning the right value for selected text range
+        https://bugs.webkit.org/show_bug.cgi?id=153260
+
+        Reviewed by Darin Adler.
+
+        * accessibility/selected-text-range-aria-elements-expected.txt: Added.
+        * accessibility/selected-text-range-aria-elements.html: Added.
+
 2016-01-21  Dave Hyatt  <hyatt@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-01-22  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: ARIA combo boxes are not returning the right value for selected text range
+        https://bugs.webkit.org/show_bug.cgi?id=153260
+
+        Reviewed by Darin Adler.
+
+        Just because an element has an ARIA role doesn't mean we should always use the selected text range of the whole document.
+        If the element is also a text based ARIA control, we can still use the element's inner text range to return the right value.
+
+        Test: accessibility/selected-text-range-aria-elements.html
+
+        * accessibility/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::selectedTextRange):
+
 2016-01-22  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

@@ -1494 +1494 @@
     
     AccessibilityRole ariaRole = ariaRoleAttribute();
-    if (isNativeTextControl() && ariaRole == UnknownRole) {
+    // Use the text control native range if it's a native object and it has no ARIA role (or has a text based ARIA role).
+    if (isNativeTextControl() && (ariaRole == UnknownRole || isARIATextControl())) {
         HTMLTextFormControlElement& textControl = downcast<RenderTextControl>(*m_renderer).textFormControlElement();
         return PlainTextRange(textControl.selectionStart(), textControl.selectionEnd() - textControl.selectionStart());