Changeset 195463 in webkit
- Timestamp:
- Jan 22, 2016 11:31:22 AM (8 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 10 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r195461 r195463 1 2016-01-22 Chris Fleizach <cfleizach@apple.com> 2 3 AX: <code> group and friends should have a custom subrole 4 https://bugs.webkit.org/show_bug.cgi?id=153282 5 6 Reviewed by Mario Sanchez Prada. 7 8 * accessibility/duplicate-child-nodes-expected.txt: 9 * accessibility/mac/subroles-for-formatted-groups-expected.txt: Added. 10 * accessibility/mac/subroles-for-formatted-groups.html: Added. 11 * accessibility/roles-computedRoleString-expected.txt: 12 * accessibility/roles-computedRoleString.html: 13 1 14 2016-01-22 Skachkov Oleksandr <gskachkov@gmail.com> 2 15 -
trunk/LayoutTests/accessibility/duplicate-child-nodes-expected.txt
r95018 r195463 4 4 5 5 6 PASS webArea.childAtIndex(0).isEqual(webArea.childAtIndex(1)) is false 6 7 PASS successfullyParsed is true 7 8 -
trunk/LayoutTests/accessibility/roles-computedRoleString-expected.txt
r186692 r195463 43 43 PASS: input[type='url'] -> . 44 44 PASS: input[type='week'] -> . 45 PASS: ins -> group. 45 46 PASS: math -> math. 46 47 PASS: meter -> progressbar. … … 49 50 PASS: li -> listitem. 50 51 PASS: p -> . 51 PASS: pre -> .52 PASS: pre -> group. 52 53 PASS: progress -> progressbar. 54 PASS: samp -> group. 53 55 PASS: section -> region. 54 56 PASS: select:not([multiple]) -> . … … 75 77 PASS: ul -> list. 76 78 PASS: li -> listitem. 79 PASS: var -> group. 77 80 PASS: div[role="command"] -> . 78 81 PASS: div[role="composite"] -> . -
trunk/LayoutTests/accessibility/roles-computedRoleString.html
r186692 r195463 53 53 <input type="url" value="X" data-role="" class="ex" data-note="[type='url']"> 54 54 <input type="week" value="X" data-role="" class="ex" data-note="[type='week']"> 55 <ins data-role=" " class="ex">X</ins>55 <ins data-role="group" class="ex">X</ins> 56 56 <mark data-role="" class="ex">X</mark> 57 57 <math data-role="math" class="ex">X</math> … … 70 70 <p data-role="" class="ex">X</p> 71 71 <!-- skipped <param> --> 72 <pre data-role=" " class="ex">X</pre>72 <pre data-role="group" class="ex">X</pre> 73 73 <progress data-role="progressbar" class="ex" value="0.75">X</progress> 74 74 <q data-role="" class="ex">X</q> 75 75 <!-- skipped <ruby/rp/rt> --> 76 76 <s data-role="" class="ex">X</s> 77 <samp data-role=" " class="ex">X</samp>77 <samp data-role="group" class="ex">X</samp> 78 78 <!-- skipped <script> --> 79 79 <section data-role="region" class="ex">X</section> … … 141 141 <li data-role="listitem" class="ex">X</li> 142 142 </ul> 143 <var data-role=" " class="ex">X</var>143 <var data-role="group" class="ex">X</var> 144 144 <wbr data-role="" class="ex">X</wbr> 145 145 -
trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt
r188203 r195463 71 71 72 72 cite 73 AXRole: 74 AXSubrole: 75 AXRoleDescription: 73 AXRole: AXGroup 74 AXSubrole: AXCiteStyleGroup 75 AXRoleDescription: group 76 76 77 77 code 78 AXRole: 79 AXSubrole: 80 AXRoleDescription: 78 AXRole: AXGroup 79 AXSubrole: AXCodeStyleGroup 80 AXRoleDescription: group 81 81 82 82 del:not([datetime]) 83 AXRole: 84 AXSubrole: 85 AXRoleDescription: 83 AXRole: AXGroup 84 AXSubrole: AXDeleteStyleGroup 85 AXRoleDescription: group 86 86 87 87 del[datetime] 88 AXRole: 89 AXSubrole: 90 AXRoleDescription: 88 AXRole: AXGroup 89 AXSubrole: AXDeleteStyleGroup 90 AXRoleDescription: group 91 91 92 92 dfn … … 336 336 337 337 ins:not([datetime]) 338 AXRole: 339 AXSubrole: 340 AXRoleDescription: 338 AXRole: AXGroup 339 AXSubrole: AXInsertStyleGroup 340 AXRoleDescription: group 341 341 342 342 ins[datetime] 343 AXRole: 344 AXSubrole: 345 AXRoleDescription: 343 AXRole: AXGroup 344 AXSubrole: AXInsertStyleGroup 345 AXRoleDescription: group 346 346 347 347 map … … 557 557 pre 558 558 AXRole: AXGroup 559 AXSubrole: 559 AXSubrole: AXPreformattedStyleGroup 560 560 AXRoleDescription: group 561 561 … … 576 576 577 577 samp 578 AXRole: 579 AXSubrole: 580 AXRoleDescription: 578 AXRole: AXGroup 579 AXSubrole: AXSampleStyleGroup 580 AXRoleDescription: group 581 581 582 582 section … … 731 731 732 732 var 733 AXRole: 734 AXSubrole: 735 AXRoleDescription: 733 AXRole: AXGroup 734 AXSubrole: AXVariableStyleGroup 735 AXRoleDescription: group 736 736 737 737 wbr -
trunk/Source/WebCore/ChangeLog
r195459 r195463 1 2016-01-22 Chris Fleizach <cfleizach@apple.com> 2 3 AX: <code> group and friends should have a custom subrole 4 https://bugs.webkit.org/show_bug.cgi?id=153282 5 6 Reviewed by Mario Sanchez Prada. 7 8 Add some custom subroles for the mac for code, ins, del, cite, var, samp, pre, kbd, 9 so that assistive tech can recognize them. 10 11 Test: accessibility/mac/subroles-for-formatted-groups.html 12 13 * accessibility/AccessibilityObject.cpp: 14 (WebCore::AccessibilityObject::isStyleFormatGroup): 15 * accessibility/AccessibilityObject.h: 16 * accessibility/AccessibilityRenderObject.cpp: 17 (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored): 18 (WebCore::AccessibilityRenderObject::determineAccessibilityRole): 19 * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: 20 (-[WebAccessibilityObjectWrapper subrole]): 21 1 22 2016-01-22 Enrica Casucci <enrica@apple.com> 2 23 -
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
r195452 r195463 2941 2941 #endif 2942 2942 2943 bool AccessibilityObject::is ContainedByPasswordField() const2943 bool AccessibilityObject::isStyleFormatGroup() const 2944 2944 { 2945 2945 Node* node = this->node(); … … 2947 2947 return false; 2948 2948 2949 return node->hasTagName(kbdTag) || node->hasTagName(codeTag) 2950 || node->hasTagName(preTag) || node->hasTagName(sampTag) 2951 || node->hasTagName(varTag) || node->hasTagName(citeTag) 2952 || node->hasTagName(insTag) || node->hasTagName(delTag); 2953 } 2954 2955 bool AccessibilityObject::isContainedByPasswordField() const 2956 { 2957 Node* node = this->node(); 2958 if (!node) 2959 return false; 2960 2949 2961 if (ariaRoleAttribute() != UnknownRole) 2950 2962 return false; -
trunk/Source/WebCore/accessibility/AccessibilityObject.h
r195240 r195463 541 541 bool isSplitter() const { return roleValue() == SplitterRole; } 542 542 bool isToolbar() const { return roleValue() == ToolbarRole; } 543 543 bool isStyleFormatGroup() const; 544 544 545 virtual bool isChecked() const { return false; } 545 546 virtual bool isEnabled() const { return false; } -
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
r195457 r195463 1387 1387 return false; 1388 1388 1389 if (isStyleFormatGroup()) 1390 return false; 1391 1389 1392 // Make sure that ruby containers are not ignored. 1390 1393 if (m_renderer->isRubyRun() || m_renderer->isRubyBlock() || m_renderer->isRubyInline()) … … 2582 2585 if (node && node->hasTagName(SVGNames::gTag)) 2583 2586 return GroupRole; 2584 2587 2588 if (isStyleFormatGroup()) 2589 return GroupRole; 2590 2585 2591 #if ENABLE(MATHML) 2586 2592 if (node && node->hasTagName(MathMLNames::mathTag)) -
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
r195240 r195463 2362 2362 return NSAccessibilitySwitchSubrole; 2363 2363 2364 if (role == GroupRole) { 2365 if (Node* node = m_object->node()) { 2366 if (node->hasTagName(kbdTag)) 2367 return @"AXKeyboardInputStyleGroup"; 2368 if (node->hasTagName(codeTag)) 2369 return @"AXCodeStyleGroup"; 2370 if (node->hasTagName(preTag)) 2371 return @"AXPreformattedStyleGroup"; 2372 if (node->hasTagName(sampTag)) 2373 return @"AXSampleStyleGroup"; 2374 if (node->hasTagName(varTag)) 2375 return @"AXVariableStyleGroup"; 2376 if (node->hasTagName(citeTag)) 2377 return @"AXCiteStyleGroup"; 2378 if (node->hasTagName(insTag)) 2379 return @"AXInsertStyleGroup"; 2380 if (node->hasTagName(delTag)) 2381 return @"AXDeleteStyleGroup"; 2382 } 2383 } 2384 2364 2385 // Ruby subroles 2365 2386 switch (role) {
Note: See TracChangeset
for help on using the changeset viewer.