Changeset 195558 in webkit


Ignore:
Timestamp:
Jan 25, 2016 3:08:03 PM (8 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r195543.
​https://bugs.webkit.org/show_bug.cgi?id=153451

regressed performance of test bots by ~6% (Requested by dydz
on #webkit).

Reverted changeset:

"WebKitTestRunner: Credential cache is not cleared between
tests"
​https://bugs.webkit.org/show_bug.cgi?id=153407
​http://trac.webkit.org/changeset/195543

Location:
trunk
Files:
13 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit2/ChangeLog

    r195555 r195558  
     12016-01-25  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r195543.
     4        https://bugs.webkit.org/show_bug.cgi?id=153451
     5
     6        regressed performance of test bots by ~6% (Requested by dydz
     7        on #webkit).
     8
     9        Reverted changeset:
     10
     11        "WebKitTestRunner: Credential cache is not cleared between
     12        tests"
     13        https://bugs.webkit.org/show_bug.cgi?id=153407
     14        http://trac.webkit.org/changeset/195543
     15
    1162016-01-25  Chris Dumez  <cdumez@apple.com>
    217

  • trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp

    r195543 r195558  
    256256}
    257257
    258 void NetworkProcess::switchToNewTestingSession()
    259 {
    260     NetworkStorageSession::switchToNewTestingSession();
    261 }
    262 
    263258void NetworkProcess::ensurePrivateBrowsingSession(SessionID sessionID)
    264259{

  • trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h

    r195543 r195558  
    147147    void deleteWebsiteDataForOrigins(WebCore::SessionID, uint64_t websiteDataTypes, const Vector<WebCore::SecurityOriginData>& origins, const Vector<String>& cookieHostNames, uint64_t callbackID);
    148148
    149     void switchToNewTestingSession();
    150 
    151149    // FIXME: This should take a session ID so we can identify which disk cache to delete.
    152150    void clearDiskCache(std::chrono::system_clock::time_point modifiedSince, std::function<void ()> completionHandler);

  • trunk/Source/WebKit2/NetworkProcess/NetworkProcess.messages.in

    r195543 r195558  
    3333#endif
    3434
    35     SwitchToNewTestingSession()
    36 
    3735    EnsurePrivateBrowsingSession(WebCore::SessionID sessionID)
    3836    DestroyPrivateBrowsingSession(WebCore::SessionID sessionID)

  • trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp

    r195543 r195558  
    539539}
    540540
    541 void WKContextResetTestingNetworkSession(WKContextRef context)
    542 {
    543     toImpl(context)->resetTestingNetworkSession();
    544 }
    545 
    546541WKDictionaryRef WKContextCopyPlugInAutoStartOriginHashes(WKContextRef contextRef)
    547542{

  • trunk/Source/WebKit2/UIProcess/API/C/WKContextPrivate.h

    r195543 r195558  
    8383WK_EXPORT void WKContextUseTestingNetworkSession(WKContextRef context);
    8484
    85 // Test only. Should be called before running a test.
    86 WK_EXPORT void WKContextResetTestingNetworkSession(WKContextRef context);
    87 
    8885typedef void (*WKContextInvalidMessageFunction)(WKStringRef messageName);
    8986WK_EXPORT void WKContextSetInvalidMessageFunction(WKContextInvalidMessageFunction invalidMessageFunction);

  • trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp

    r195543 r195558  
    10741074}
    10751075
    1076 void WebProcessPool::resetTestingNetworkSession()
    1077 {
    1078     ASSERT(!m_processes.isEmpty());
    1079     ASSERT(m_networkProcess);
    1080 
    1081     if (!m_shouldUseTestingNetworkSession || !m_networkProcess || m_processes.isEmpty())
    1082         return;
    1083 
    1084     sendToAllProcesses(Messages::WebProcess::SwitchToNewTestingSession());
    1085     m_networkProcess->send(Messages::NetworkProcess::SwitchToNewTestingSession(), 0);
    1086 }
    1087 
    10881076void WebProcessPool::allowSpecificHTTPSCertificateForHost(const WebCertificateInfo* certificate, const String& host)
    10891077{

  • trunk/Source/WebKit2/UIProcess/WebProcessPool.h

    r195543 r195558  
    240240
    241241    void useTestingNetworkSession();
    242     void resetTestingNetworkSession();
    243242    bool isUsingTestingNetworkSession() const { return m_shouldUseTestingNetworkSession; }
    244243

  • trunk/Source/WebKit2/WebProcess/WebProcess.cpp

    r195543 r195558  
    499499}
    500500
    501 void WebProcess::switchToNewTestingSession()
    502 {
    503     NetworkStorageSession::switchToNewTestingSession();
    504 }
    505 
    506501WebPage* WebProcess::focusedWebPage() const
    507502{   

  • trunk/Source/WebKit2/WebProcess/WebProcess.h

    r195543 r195558  
    211211    void platformInitializeWebProcess(WebProcessCreationParameters&&);
    212212
    213     void switchToNewTestingSession();
    214 
    215213    void platformTerminate();
    216214    void registerURLSchemeAsEmptyDocument(const String&);

  • trunk/Source/WebKit2/WebProcess/WebProcess.messages.in

    r195543 r195558  
    4545    UserPreferredLanguagesChanged(Vector<String> languages)
    4646    FullKeyboardAccessModeChanged(bool fullKeyboardAccessEnabled)
    47 
    48     SwitchToNewTestingSession()
    4947
    5048    // Legacy private browsing session is per process. Individual pages or page groups may use the private session or the default one as appropriate.

  • trunk/Tools/ChangeLog

    r195557 r195558  
     12016-01-25  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r195543.
     4        https://bugs.webkit.org/show_bug.cgi?id=153451
     5
     6        regressed performance of test bots by ~6% (Requested by dydz
     7        on #webkit).
     8
     9        Reverted changeset:
     10
     11        "WebKitTestRunner: Credential cache is not cleared between
     12        tests"
     13        https://bugs.webkit.org/show_bug.cgi?id=153407
     14        http://trac.webkit.org/changeset/195543
     15
    1162016-01-25  Aakash Jain  <aakash_jain@apple.com>
    217

  • trunk/Tools/WebKitTestRunner/TestController.cpp

    r195543 r195558  
    715715    WKContextSetCacheModel(TestController::singleton().context(), kWKCacheModelDocumentBrowser);
    716716
    717     WKContextResetTestingNetworkSession(TestController::singleton().context());
    718 
    719717    // FIXME: This function should also ensure that there is only one page open.
    720718
Note: See TracChangeset for help on using the changeset viewer.