Changeset 195601 in webkit

Timestamp:

Jan 26, 2016 11:02:40 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Fix build with ENABLE_DEVICE_ORIENTATION on non-iOS platforms
​https://bugs.webkit.org/show_bug.cgi?id=153490

Patch by Olivier Blin <Olivier Blin> on 2016-01-26
Reviewed by Michael Catanzaro.

This has been broken since r178702, which changed the Page
argument from a pointer to a reference in logCanCachePageDecision().

No new tests since this is a build fix.

• history/PageCache.cpp:

(WebCore::canCachePage):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• history/PageCache.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-01-26  Olivier Blin  <olivier.blin@softathome.com>
+
+        Fix build with ENABLE_DEVICE_ORIENTATION on non-iOS platforms
+        https://bugs.webkit.org/show_bug.cgi?id=153490
+
+        Reviewed by Michael Catanzaro.
+
+        This has been broken since r178702, which changed the Page
+        argument from a pointer to a reference in logCanCachePageDecision().
+
+        No new tests since this is a build fix.
+
+        * history/PageCache.cpp:
+        (WebCore::canCachePage):
+
 2016-01-25  Ada Chan  <adachan@apple.com>
 

trunk/Source/WebCore/history/PageCache.cpp

@@ -199 +199 @@
     }
 #if ENABLE(DEVICE_ORIENTATION) && !PLATFORM(IOS)
-    if (DeviceMotionController::isActiveAt(page)) {
+    if (DeviceMotionController::isActiveAt(&page)) {
         PCLOG("   -Page is using DeviceMotion");
         logPageCacheFailureDiagnosticMessage(diagnosticLoggingClient, DiagnosticLoggingKeys::deviceMotionKey());
         isCacheable = false;
     }
-    if (DeviceOrientationController::isActiveAt(page)) {
+    if (DeviceOrientationController::isActiveAt(&page)) {
         PCLOG("   -Page is using DeviceOrientation");
         logPageCacheFailureDiagnosticMessage(diagnosticLoggingClient, DiagnosticLoggingKeys::deviceOrientationKey());