Changeset 195653 in webkit

Timestamp:

Jan 26, 2016 7:49:35 PM (8 years ago)

Author:

fpizlo@apple.com

Message:

Tail duplication should break critical edges first
​https://bugs.webkit.org/show_bug.cgi?id=153530

Reviewed by Benjamin Poulain.

This speeds up Octane/boyer.

• b3/B3DuplicateTails.cpp:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• b3/B3DuplicateTails.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-01-26  Filip Pizlo  <fpizlo@apple.com>
+
+        Tail duplication should break critical edges first
+        https://bugs.webkit.org/show_bug.cgi?id=153530
+
+        Reviewed by Benjamin Poulain.
+
+        This speeds up Octane/boyer.
+
+        * b3/B3DuplicateTails.cpp:
+
 2016-01-26  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/JavaScriptCore/b3/B3DuplicateTails.cpp

@@ -30 +30 @@
 
 #include "B3BasicBlockInlines.h"
+#include "B3BreakCriticalEdges.h"
 #include "B3ControlValue.h"
 #include "B3Dominators.h"
@@ -59 +60 @@
     void run()
     {
+        // Breaking critical edges introduces blocks that jump to things. Those Jumps' successors
+        // become candidates for tail duplication. Prior to critical edge breaking, some of those
+        // Jumps would have been Branches, and so no tail duplication would have happened.
+        breakCriticalEdges(m_proc);
+        
         // Find blocks that would be candidates for tail duplication. They must be small enough
         // and they much not have too many successors.