Changeset 19572 in webkit

Timestamp:

Feb 11, 2007 11:37:07 PM (17 years ago)

Author:

beidson

Message:

Reviewed by Maciej

First in what will be a series of HistoryItem enhancements to help debugging

• history/HistoryItem.cpp: (WebCore::HistoryItem::showTree): (WebCore::HistoryItem::showTreeWithIndent): (showTree): Outside of WebCore namespace, and extern "C" - to make even the DWARF debugger able to find it... *sigh*
• history/HistoryItem.h:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• history/HistoryItem.cpp (modified) (2 diffs)
• history/HistoryItem.h (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-02-11  Brady Eidson <beidson@apple.com>
+
+        Reviewed by Maciej
+
+        First in what will be a series of HistoryItem enhancements to help debugging
+
+        * history/HistoryItem.cpp:
+        (WebCore::HistoryItem::showTree):
+        (WebCore::HistoryItem::showTreeWithIndent):
+        (showTree): Outside of WebCore namespace, and extern "C" - to make even the 
+          DWARF debugger able to find it...  *sigh* 
+        * history/HistoryItem.h:
+
 2007-02-11  Eric Seidel  <eric@webkit.org>
 

trunk/WebCore/history/HistoryItem.cpp

@@ -503 +503 @@
 }
 #ifndef NDEBUG
-void HistoryItem::print() const
-{
-    fprintf(stderr, "%s\n", m_urlString.ascii().data());
+int HistoryItem::showTree() const
+{
+    return showTreeWithIndent(0);
+}
+
+int HistoryItem::showTreeWithIndent(unsigned indentLevel) const
+{
+    String prefix("");
+    int totalSubItems = 0;
+    unsigned i;
+    for (i = 0; i < indentLevel; ++i)
+        prefix.append("  ");
+
+    fprintf(stderr, "%s+-%s (%p)\n", prefix.ascii().data(), m_urlString.ascii().data(), this);
+    
+    for (unsigned int i = 0; i < m_subItems.size(); ++i) {
+        totalSubItems += m_subItems[i]->showTreeWithIndent(indentLevel + 1);
+    }
+    return totalSubItems + 1;
 }
 #endif
@@ -511 +527 @@
 }; //namespace WebCore
 
+#ifndef NDEBUG
+int showTree(const WebCore::HistoryItem* item)
+{
+    return item->showTree();
+}
+#endif
+

trunk/WebCore/history/HistoryItem.h

@@ -148 +148 @@
     
 #ifndef NDEBUG
-    void print() const;
+    int showTree() const;
+    int showTreeWithIndent(unsigned indentLevel) const;
 #endif
 
@@ -191 +192 @@
 } //namespace WebCore
 
+#ifndef NDEBUG
+// Outside the WebCore namespace for ease of invocation from gdb.
+extern "C" int showTree(const WebCore::HistoryItem*);
+#endif
+
 #endif // HISTORYITEM_H