Changeset 195809 in webkit


Ignore:
Timestamp:
Jan 29, 2016 1:58:02 AM (8 years ago)
Author:
ChangSeok Oh
Message:

[GStreamer] built-in media player doesn't update
https://bugs.webkit.org/show_bug.cgi?id=151816

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

The timeline of audio controls in media document is not properly updated since it is assumed
that the controls are hidden as soon as playing. However, such full page audio always has
opacity : 1 declared by video:-webkit-full-page-media::-webkit-media-controls-panel.no-video.
i.e. it is not actually hidden. We can fix this by simply returning false for no-video media
in controlsAreHidden();

Test: media/audio-controls-timeline-in-media-document.html

  • Modules/mediacontrols/mediaControlsBase.js:

(Controller.prototype.controlsAreAlwaysVisible):
(Controller.prototype.controlsAreHidden):

LayoutTests:

  • media/audio-controls-timeline-in-media-document-expected.txt: Added.
  • media/audio-controls-timeline-in-media-document.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r195801 r195809  
     12016-01-29  ChangSeok Oh  <changseok.oh@collabora.com>
     2
     3        [GStreamer] built-in media player doesn't update
     4        https://bugs.webkit.org/show_bug.cgi?id=151816
     5
     6        Reviewed by Xabier Rodriguez-Calvar.
     7
     8        * media/audio-controls-timeline-in-media-document-expected.txt: Added.
     9        * media/audio-controls-timeline-in-media-document.html: Added.
     10
    1112016-01-28  Brady Eidson  <beidson@apple.com>
    212
  • trunk/Source/WebCore/ChangeLog

    r195808 r195809  
     12016-01-29  ChangSeok Oh  <changseok.oh@collabora.com>
     2
     3        [GStreamer] built-in media player doesn't update
     4        https://bugs.webkit.org/show_bug.cgi?id=151816
     5
     6        Reviewed by Xabier Rodriguez-Calvar.
     7
     8        The timeline of audio controls in media document is not properly updated since it is assumed
     9        that the controls are hidden as soon as playing. However, such full page audio always has
     10        opacity : 1 declared by video:-webkit-full-page-media::-webkit-media-controls-panel.no-video.
     11        i.e. it is not actually hidden. We can fix this by simply returning false for no-video media
     12        in controlsAreHidden();
     13
     14        Test: media/audio-controls-timeline-in-media-document.html
     15
     16        * Modules/mediacontrols/mediaControlsBase.js:
     17        (Controller.prototype.controlsAreAlwaysVisible):
     18        (Controller.prototype.controlsAreHidden):
     19
    1202016-01-29  Manuel Rego Casasnovas  <rego@igalia.com>
    221
  • trunk/Source/WebCore/Modules/mediacontrols/mediaControlsBase.js

    r192570 r195809  
    10251025    },
    10261026
     1027    controlsAreAlwaysVisible: function()
     1028    {
     1029        return this.controls.panel.classList.contains(this.ClassNames.noVideo);
     1030    },
     1031
    10271032    controlsAreHidden: function()
    10281033    {
     1034        if (this.controlsAreAlwaysVisible())
     1035            return false;
     1036
    10291037        var panel = this.controls.panel;
    10301038        return (!panel.classList.contains(this.ClassNames.show) || panel.classList.contains(this.ClassNames.hidden))
Note: See TracChangeset for help on using the changeset viewer.