Changeset 195842 in webkit

Timestamp:

Jan 29, 2016 2:59:20 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: WebInspector.Setting should not access localStorage if the value did not change
​https://bugs.webkit.org/show_bug.cgi?id=153671
<rdar://problem/24417029>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-29
Reviewed by Brian Burg.

• UserInterface/Base/Setting.js:

(WebInspector.Setting.prototype.set value):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Base/Setting.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-01-29  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: WebInspector.Setting should not access localStorage if the value did not change
+        https://bugs.webkit.org/show_bug.cgi?id=153671
+        <rdar://problem/24417029>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Base/Setting.js:
+        (WebInspector.Setting.prototype.set value):
+
 2016-01-29  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js

@@ -72 +72 @@
     set value(value)
     {
+        if (this._value === value)
+            return;
+
         this._value = value;