Changeset 195863 in webkit

Timestamp:

Jan 29, 2016 4:06:48 PM (8 years ago)

Author:

rniwa@webkit.org

Message:

fast/shadow-dom/Element-interface-attachShadow.html fails on iOS
​https://bugs.webkit.org/show_bug.cgi?id=153681

Reviewed by Antti Koivisto.

Source/WebCore:

The bug was caused by canHaveUserAgentShadowRoot() returning false on a meter element since it's disabled on iOS.
Override HTMLUnknownElement's canHaveUserAgentShadowRoot to return false for compatbility on iOS.

• html/HTMLUnknownElement.h:

(WebCore::HTMLUnknownElement::canHaveUserAgentShadowRoot):

LayoutTests:

Enable shadow DOM and custom elements tests on iOS; matches that's in platform/mac/TestExpectations.

• platform/ios-simulator/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/ios-simulator/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLUnknownElement.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-01-29  Ryosuke Niwa  <rniwa@webkit.org>
+
+        fast/shadow-dom/Element-interface-attachShadow.html fails on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=153681
+
+        Reviewed by Antti Koivisto.
+
+        Enable shadow DOM and custom elements tests on iOS; matches that's in platform/mac/TestExpectations.
+
+        * platform/ios-simulator/TestExpectations:
+
 2016-01-29  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/LayoutTests/platform/ios-simulator/TestExpectations

@@ -215 +215 @@
 fast/loader/stateobjects/replacestate-frequency-with-user-gesture.html [ Skip ]
 fast/loader/stateobjects/pushstate-frequency-with-user-gesture.html [ Skip ]
+
+webkit.org/b/148695 fast/shadow-dom [ Pass ]
+webkit.org/b/149440 fast/shadow-dom/css-scoping-shadow-host-functional-rule.html [ ImageOnlyFailure ]
+webkit.org/b/149441 fast/shadow-dom/css-scoping-shadow-slotted-rule.html [ ImageOnlyFailure ]
+webkit.org/b/149441 fast/shadow-dom/css-scoping-shadow-slot-display-override.html [ ImageOnlyFailure ]
+
+webkit.org/b/150225 fast/custom-elements [ Pass ]
 
 ###

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-01-29  Ryosuke Niwa  <rniwa@webkit.org>
+
+        fast/shadow-dom/Element-interface-attachShadow.html fails on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=153681
+
+        Reviewed by Antti Koivisto.
+
+        The bug was caused by canHaveUserAgentShadowRoot() returning false on a meter element since it's disabled on iOS.
+        Override HTMLUnknownElement's canHaveUserAgentShadowRoot to return false for compatbility on iOS.
+
+        * html/HTMLUnknownElement.h:
+        (WebCore::HTMLUnknownElement::canHaveUserAgentShadowRoot):
+
 2016-01-29  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebCore/html/HTMLUnknownElement.h

@@ -48 +48 @@
     }
 
+#if ENABLE(METER_ELEMENT)
+    virtual bool canHaveUserAgentShadowRoot() const override final { return false; }
+#else
+    virtual bool canHaveUserAgentShadowRoot() const override final { return localName() == "meter"; }
+#endif
+
     virtual bool isHTMLUnknownElement() const override { return true; }
 };