Changeset 195924 in webkit

Timestamp:

Jan 31, 2016 1:20:05 AM (8 years ago)

Author:

youenn.fablet@crf.canon.fr

Message:

imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html asserts frequently
​https://bugs.webkit.org/show_bug.cgi?id=152436

Reviewed by Darin Adler.

GCController is not available in Worker environments, explaining probably why garbage-collection-2.html is not crashing at all.
Inlining half of the tests in garbage-collection-2.html (runned in window) to compare with garbage-collection-1.html.

• web-platform-tests/streams-api/readable-streams/garbage-collection-2-expected.txt:
• web-platform-tests/streams-api/readable-streams/garbage-collection-2.html:

Location:

trunk/LayoutTests/imported/w3c

Files:

• ChangeLog (modified) (1 diff)
• web-platform-tests/streams-api/readable-streams/garbage-collection-2-expected.txt (modified) (1 diff)
• web-platform-tests/streams-api/readable-streams/garbage-collection-2.html (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2016-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
+
+        imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html asserts frequently
+        https://bugs.webkit.org/show_bug.cgi?id=152436
+
+        Reviewed by Darin Adler.
+
+        GCController is not available in Worker environments, explaining probably why garbage-collection-2.html is not crashing at all.
+        Inlining half of the tests in garbage-collection-2.html (runned in window) to compare with garbage-collection-1.html.
+
+        * web-platform-tests/streams-api/readable-streams/garbage-collection-2-expected.txt:
+        * web-platform-tests/streams-api/readable-streams/garbage-collection-2.html:
+
 2016-01-30  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-2-expected.txt

@@ -2 +2 @@
 PASS ReadableStreamController methods should continue working properly when scripts lose their reference to the readable stream 
 PASS ReadableStream closed promise should fulfill even if the stream and reader JS references are lost 
-PASS ReadableStream closed promise should reject even if stream and reader JS references are lost 
-PASS Garbage-collecting a ReadableStreamReader should not unlock its stream 
 

trunk/LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-2.html

@@ -10 +10 @@
 <script>
 'use strict';
-fetch_tests_from_worker(new Worker('garbage-collection.js'));
+
+promise_test(() => {
+
+  let controller;
+  new ReadableStream({
+    start(c) {
+      controller = c;
+    }
+  });
+
+  garbageCollect();
+
+  return delay(50).then(() => {
+    controller.close();
+    assert_throws(new TypeError(), () => controller.close(), 'close should throw a TypeError the second time');
+    assert_throws(new TypeError(), () => controller.error(), 'error should throw a TypeError on a closed stream');
+  });
+
+}, 'ReadableStreamController methods should continue working properly when scripts lose their reference to the ' +
+   'readable stream');
+
+promise_test(() => {
+
+  let controller;
+
+  const closedPromise = new ReadableStream({
+    start(c) {
+      controller = c;
+    }
+  }).getReader().closed;
+
+  garbageCollect();
+
+  return delay(50).then(() => controller.close()).then(() => closedPromise);
+
+}, 'ReadableStream closed promise should fulfill even if the stream and reader JS references are lost');
 </script>