Changeset 195967 in webkit


Ignore:
Timestamp:
Feb 1, 2016 10:24:40 AM (8 years ago)
Author:
Matt Baker
Message:

Web Inspector: Rendering Frames timeline draws all frame bars at minimum height
https://bugs.webkit.org/show_bug.cgi?id=153736
<rdar://problem/21946301>

Reviewed by Timothy Hatcher.

  • UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
Update the new timeline overview's height before it's shown. Showing the
overview causes the rendering frames graph to do a layout, which requires
the height of the containing view to be a valid value.

Location:
trunk/Source/WebInspectorUI
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r195966 r195967  
     12016-02-01  Matt Baker  <mattbaker@apple.com>
     2
     3        Web Inspector: Rendering Frames timeline draws all frame bars at minimum height
     4        https://bugs.webkit.org/show_bug.cgi?id=153736
     5        <rdar://problem/21946301>
     6
     7        Reviewed by Timothy Hatcher.
     8
     9        * UserInterface/Views/TimelineRecordingContentView.js:
     10        (WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
     11        Update the new timeline overview's height before it's shown. Showing the
     12        overview causes the rendering frames graph to do a layout, which requires
     13        the height of the containing view to be a valid value.
     14
    1152016-02-01  Matt Baker  <mattbaker@apple.com>
    216
  • trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js

    r195881 r195967  
    353353
    354354            this._currentTimelineOverview = newTimelineOverview;
     355
     356            this._updateTimelineOverviewHeight();
    355357            this._currentTimelineOverview.shown();
    356 
    357             this._updateTimelineOverviewHeight();
    358358        }
    359359
Note: See TracChangeset for help on using the changeset viewer.