Changeset 196007 in webkit


Ignore:
Timestamp:
Feb 2, 2016 4:26:38 AM (8 years ago)
Author:
g.czajkowski@samsung.com
Message:

[EFL] Virtual Keyboard overlaps MiniBrowser's WebView
https://bugs.webkit.org/show_bug.cgi?id=153009

Reviewed by Gyuyoung Kim.

On mobile, virtual keyboard represented by ecore_imf module appears on
the top of application layer usually covering bottom part of the screen.
If the web page contains the editable content on the bottom of the page
it will be overlapped by keyboard which prevents user from seeing the
typed text.

Pack MiniBrowser layout into conformant widget to allow EFL to guess
the space that will be required by the keyboard, finally resizing it
to the desired size. As a result, webview gets resized and scrolled
into focused elements which makes the editable elements visible while
typing.

More details about elm_conformant widger can be found at:
https://docs.enlightenment.org/elementary/1.15.0/group__Conformant.html
https://docs.enlightenment.org/elementary/1.15.0/conformant_example.html

  • MiniBrowser/efl/main.c:

(window_create): pack a box into conformant widget.

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r196006 r196007  
     12016-01-29 Grzegorz Czajkowski  <g.czajkowski@samsung.com>
     2
     3        [EFL] Virtual Keyboard overlaps MiniBrowser's WebView
     4        https://bugs.webkit.org/show_bug.cgi?id=153009
     5
     6        Reviewed by Gyuyoung Kim.
     7
     8        On mobile, virtual keyboard represented by ecore_imf module appears on
     9        the top of application layer usually covering bottom part of the screen.
     10        If the web page contains the editable content on the bottom of the page
     11        it will be overlapped by keyboard which prevents user from seeing the
     12        typed text.
     13
     14        Pack MiniBrowser layout into conformant widget to allow EFL to guess
     15        the space that will be required by the keyboard, finally resizing it
     16        to the desired size. As a result, webview gets resized and scrolled
     17        into focused elements which makes the editable elements visible while
     18        typing.
     19
     20        More details about elm_conformant widger can be found at:
     21        https://docs.enlightenment.org/elementary/1.15.0/group__Conformant.html
     22        https://docs.enlightenment.org/elementary/1.15.0/conformant_example.html
     23
     24        * MiniBrowser/efl/main.c:
     25        (window_create): pack a box into conformant widget.
     26
    1272016-02-02  Alejandro G. Castro  <alex@igalia.com>
    228
  • trunk/Tools/MiniBrowser/efl/main.c

    r194381 r196007  
    20892089    evas_object_show(bg);
    20902090
     2091    /* Create conformant widget. */
     2092    Evas_Object *conformant = elm_conformant_add(window->elm_window);
     2093    evas_object_size_hint_weight_set(conformant, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
     2094    elm_win_resize_object_add(window->elm_window, conformant);
     2095    evas_object_show(conformant);
     2096
    20912097    /* Create vertical layout */
    20922098    window->vertical_layout = elm_box_add(window->elm_window);
     2099    elm_object_content_set(conformant, window->vertical_layout);
    20932100    elm_box_padding_set(window->vertical_layout, 0, 2);
    20942101    evas_object_size_hint_weight_set(window->vertical_layout, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
    2095     elm_win_resize_object_add(window->elm_window, window->vertical_layout);
    20962102    evas_object_show(window->vertical_layout);
    20972103
Note: See TracChangeset for help on using the changeset viewer.