Changeset 196039 in webkit


Ignore:
Timestamp:
Feb 2, 2016 6:27:26 PM (8 years ago)
Author:
hur.ims@navercorp.com
Message:

WEBGL_debug_shaders should be disabled for OpenGLES backend also
https://bugs.webkit.org/show_bug.cgi?id=153788

Reviewed by Darin Adler.

WEBGL_debug_shaders extension is disabled for OpenGL backed platform
because the implementation is not fully compliant to the spec yet.
Because this is not an OpenGL-specific problem, WEBGL_debug_shaders extension
should be disabled for OpenGLES backed platforms also.

No new tests, already covered by existing tests.

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::supportsExtension): Deleted.

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::supports):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r196038 r196039  
     12016-02-02  Jinyoung Hur  <hur.ims@navercorp.com>
     2
     3        WEBGL_debug_shaders should be disabled for OpenGLES backend also
     4        https://bugs.webkit.org/show_bug.cgi?id=153788
     5
     6        Reviewed by Darin Adler.
     7
     8        WEBGL_debug_shaders extension is disabled for OpenGL backed platform
     9        because the implementation is not fully compliant to the spec yet.
     10        Because this is not an OpenGL-specific problem, WEBGL_debug_shaders extension
     11        should be disabled for OpenGLES backed platforms also.
     12
     13        No new tests, already covered by existing tests.
     14
     15        * platform/graphics/opengl/Extensions3DOpenGL.cpp:
     16        (WebCore::Extensions3DOpenGL::supportsExtension): Deleted.
     17        * platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
     18        (WebCore::Extensions3DOpenGLCommon::supports):
     19
    1202016-02-02  Brady Eidson  <beidson@apple.com>
    221
  • trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp

    r194933 r196039  
    172172    }
    173173
    174     // We explicitly do not support this extension until
    175     // we fix the following bug:
    176     // https://bugs.webkit.org/show_bug.cgi?id=149734
    177     if (name == "GL_ANGLE_translated_shader_source")
    178         return false;
    179 
    180174    if (name == "GL_EXT_sRGB")
    181175#if PLATFORM(IOS)
  • trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp

    r188536 r196039  
    9494        initializeAvailableExtensions();
    9595
     96    // We explicitly do not support this extension until
     97    // we fix the following bug:
     98    // https://bugs.webkit.org/show_bug.cgi?id=149734
     99    if (name == "GL_ANGLE_translated_shader_source")
     100        return false;
     101
    96102    return supportsExtension(name);
    97103}
Note: See TracChangeset for help on using the changeset viewer.