Changeset 196060 in webkit

Timestamp:

Feb 3, 2016 2:31:27 AM (8 years ago)

Author:

Carlos Garcia Campos

Message:

REGRESSION(r191948): [GStreamer] 4 new timeouts on layout tests.
​https://bugs.webkit.org/show_bug.cgi?id=152797

Reviewed by Darin Adler.

Source/WebCore:

Always schedule messages to the main thread, even when the bus
sync handlder was called in the main thread. It seems that
GStreamer expects things to happen in the next main loop
iteration.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

LayoutTests:

Update test expectations.

• platform/gtk/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-02-03  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r191948): [GStreamer] 4 new timeouts on layout tests.
+        https://bugs.webkit.org/show_bug.cgi?id=152797
+
+        Reviewed by Darin Adler.
+
+        Update test expectations.
+
+        * platform/gtk/TestExpectations:
+
 2016-02-02  Fujii Hironori  <Hironori.Fujii@jp.sony.com>
 

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -1490 +1490 @@
 webkit.org/b/144690 editing/spelling/delete-into-misspelled-word.html [ Timeout Pass ]
 
-webkit.org/b/141835 media/video-controls-no-scripting.html [ Failure Timeout ]
-webkit.org/b/152797 media/video-source-error.html [ Timeout ]
-webkit.org/b/152797 media/video-source-load.html [ Timeout ]
-webkit.org/b/152797 media/video-source-moved.html [ Timeout ]
+webkit.org/b/141835 media/video-controls-no-scripting.html [ Failure ]
 
 # May take too long on the bots.

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-02-03  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r191948): [GStreamer] 4 new timeouts on layout tests.
+        https://bugs.webkit.org/show_bug.cgi?id=152797
+
+        Reviewed by Darin Adler.
+
+        Always schedule messages to the main thread, even when the bus
+        sync handlder was called in the main thread. It seems that
+        GStreamer expects things to happen in the next main loop
+        iteration.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
+
 2016-02-03  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -1904 +1904 @@
 
         if (!player.handleSyncMessage(message)) {
-            if (isMainThread())
-                player.handleMessage(message);
-            else {
-                GRefPtr<GstMessage> protectMessage(message);
-                auto weakThis = player.createWeakPtr();
-                RunLoop::main().dispatch([weakThis, protectMessage] {
-                    if (weakThis)
-                        weakThis->handleMessage(protectMessage.get());
-                });
-            }
+            GRefPtr<GstMessage> protectedMessage(message);
+            auto weakThis = player.createWeakPtr();
+            RunLoop::main().dispatch([weakThis, protectedMessage] {
+                if (weakThis)
+                    weakThis->handleMessage(protectedMessage.get());
+            });
         }
         gst_message_unref(message);