Changeset 196150 in webkit

Timestamp:

Feb 4, 2016 2:54:02 PM (8 years ago)

Author:

eric.carlson@apple.com

Message:

media/video-size.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=124932
<rdar://problem/23336430>

Reviewed by Jer Noble.

• media/video-size.html: Add logic to retry each stage silently twice before logging failure because we can't predict how long it will take to load the poster frame.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• media/video-size.html (modified) (4 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-02-04  Eric Carlson  <eric.carlson@apple.com>
+
+        media/video-size.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=124932
+        <rdar://problem/23336430>
+
+        Reviewed by Jer Noble.
+
+        * media/video-size.html: Add logic to retry each stage silently twice before logging
+          failure because we can't predict how long it will take to load the poster frame.
+
 2016-02-04  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/media/video-size.html

@@ -9 +9 @@
             {
                 current:0,
+                retryCount: 0,
                 movies: 
                 [ 
@@ -62 +63 @@
             {
                 consoleWrite("");
+                movieInfo.current++;
+                movieInfo.retryCount = 0;
                 if (movieInfo.current >= movieInfo.movies.length)
                 {
@@ -101 +104 @@
                 var movie = movieInfo.movies[movieInfo.current];
 
+                // We can't detect when the poster has loaded and the 100ms timeout may
+                // not be long enough on a slow/loaded machine.
+                if (video.clientWidth != movie.width || video.clientHeight != movie.height
+                    || video.videoWidth != movie.videoWidth || video.videoHeight != movie.videoHeight) {
+                    if (++movieInfo.retryCount <= 2) {
+                        setTimeout(testMovie, 100);
+                        return;
+                    }
+                }
+
                 var desc = "<b>Testing movie with " + movie.description + ".</b>";
                 consoleWrite(desc);
@@ -109 +122 @@
                 testExpected("video.videoHeight", movie.videoHeight);
 
-                movieInfo.current++;
                 setupNextConfiguration();
             }