Changeset 196151 in webkit


Ignore:
Timestamp:
Feb 4, 2016 3:13:46 PM (8 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: New timeline images for instruments
https://bugs.webkit.org/show_bug.cgi?id=153884
<rdar://problem/24509429>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-04
Reviewed by Timothy Hatcher.

  • UserInterface/Views/TimelineTabContentView.js:

(WebInspector.TimelineTabContentView.iconClassNameForTimeline):
Better names and give Memory timeline a name for an icon.

  • UserInterface/Views/TreeOutline.css:

(.tree-outline.large .item .icon):
Add more padding next to large icons.

  • UserInterface/Images/ColorsLarge.png: Removed.
  • UserInterface/Images/ColorsLarge@2x.png: Removed.
  • UserInterface/Images/Frames.png: Removed.
  • UserInterface/Images/Frames@2x.png: Removed.
  • UserInterface/Images/LayoutInstrument.svg: Added.
  • UserInterface/Images/MemoryInstrument.svg: Added.
  • UserInterface/Images/NetworkInstrument.svg: Added.
  • UserInterface/Images/NetworkLarge.png: Removed.
  • UserInterface/Images/NetworkLarge@2x.png: Removed.
  • UserInterface/Images/RenderingFramesInstrument.svg: Added.
  • UserInterface/Images/ScriptLarge.png: Removed.
  • UserInterface/Images/ScriptLarge@2x.png: Removed.

Remove old timeline pngs.

  • UserInterface/Images/ScriptsInstrument.svg: Added.
  • UserInterface/Views/TimelineIcons.css:

(.network-icon .icon):
(.script-icon .icon):
(.memory-icon .icon):
(.layout-icon .icon):
(.rendering-frame-icon .icon):
Use the new SVGs.

(body:not(.mac-platform, .windows-platform) .network-icon .icon):
(body:not(.mac-platform, .windows-platform) .network-icon.large .icon):
(body:not(.mac-platform, .windows-platform) .layout-icon .icon):
(body:not(.mac-platform, .windows-platform) .layout-icon.large .icon):
(body:not(.mac-platform, .windows-platform) .script-icon .icon):
(body:not(.mac-platform, .windows-platform) .script-icon.large .icon):
(body:not(.mac-platform, .windows-platform) .rendering-frame-icon .icon):
Fallback to old icons for non-Mac/Windows ports using Images/gtk images.

Location:
trunk/Source/WebInspectorUI
Files:
5 added
8 deleted
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r196146 r196151  
     12016-02-04  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Web Inspector: New timeline images for instruments
     4        https://bugs.webkit.org/show_bug.cgi?id=153884
     5        <rdar://problem/24509429>
     6
     7        Reviewed by Timothy Hatcher.
     8
     9        * UserInterface/Views/TimelineTabContentView.js:
     10        (WebInspector.TimelineTabContentView.iconClassNameForTimeline):
     11        Better names and give Memory timeline a name for an icon.
     12
     13        * UserInterface/Views/TreeOutline.css:
     14        (.tree-outline.large .item .icon):
     15        Add more padding next to large icons.
     16
     17        * UserInterface/Images/ColorsLarge.png: Removed.
     18        * UserInterface/Images/ColorsLarge@2x.png: Removed.
     19        * UserInterface/Images/Frames.png: Removed.
     20        * UserInterface/Images/Frames@2x.png: Removed.
     21        * UserInterface/Images/LayoutInstrument.svg: Added.
     22        * UserInterface/Images/MemoryInstrument.svg: Added.
     23        * UserInterface/Images/NetworkInstrument.svg: Added.
     24        * UserInterface/Images/NetworkLarge.png: Removed.
     25        * UserInterface/Images/NetworkLarge@2x.png: Removed.
     26        * UserInterface/Images/RenderingFramesInstrument.svg: Added.
     27        * UserInterface/Images/ScriptLarge.png: Removed.
     28        * UserInterface/Images/ScriptLarge@2x.png: Removed.
     29        Remove old timeline pngs.
     30
     31        * UserInterface/Images/ScriptsInstrument.svg: Added.
     32        * UserInterface/Views/TimelineIcons.css:
     33        (.network-icon .icon):
     34        (.script-icon .icon):
     35        (.memory-icon .icon):
     36        (.layout-icon .icon):
     37        (.rendering-frame-icon .icon):
     38        Use the new SVGs.
     39
     40        (body:not(.mac-platform, .windows-platform) .network-icon .icon):
     41        (body:not(.mac-platform, .windows-platform) .network-icon.large .icon):
     42        (body:not(.mac-platform, .windows-platform) .layout-icon .icon):
     43        (body:not(.mac-platform, .windows-platform) .layout-icon.large .icon):
     44        (body:not(.mac-platform, .windows-platform) .script-icon .icon):
     45        (body:not(.mac-platform, .windows-platform) .script-icon.large .icon):
     46        (body:not(.mac-platform, .windows-platform) .rendering-frame-icon .icon):
     47        Fallback to old icons for non-Mac/Windows ports using Images/gtk images.
     48
    1492016-02-04  Devin Rousso  <dcrousso+webkit@gmail.com>
    250
  • trunk/Source/WebInspectorUI/UserInterface/Views/TimelineIcons.css

    r195645 r196151  
    2525
    2626.network-icon .icon {
     27    content: url(../Images/NetworkInstrument.svg);
     28}
     29
     30.script-icon .icon {
     31    content: url(../Images/ScriptsInstrument.svg);
     32}
     33
     34.memory-icon .icon {
     35    content: url(../Images/MemoryInstrument.svg);
     36}
     37
     38.layout-icon .icon {
     39    content: url(../Images/LayoutInstrument.svg);
     40}
     41
     42.rendering-frame-icon .icon {
     43    content: url(../Images/RenderingFramesInstrument.svg);
     44}
     45
     46/* FIXME: <https://webkit.org/b/153892> [GTK] Web Inspector: Add new GTK+ icons for instrument icons */
     47body:not(.mac-platform, .windows-platform) .network-icon .icon {
    2748    content: -webkit-image-set(url(../Images/Network.png) 1x, url(../Images/Network@2x.png) 2x);
    2849}
    2950
    30 .network-icon.large .icon {
     51body:not(.mac-platform, .windows-platform) .network-icon.large .icon {
    3152    content: -webkit-image-set(url(../Images/NetworkLarge.png) 1x, url(../Images/NetworkLarge@2x.png) 2x);
    3253}
    3354
    34 .colors-icon .icon {
     55body:not(.mac-platform, .windows-platform) .layout-icon .icon {
    3556    content: -webkit-image-set(url(../Images/Colors.png) 1x, url(../Images/Colors@2x.png) 2x);
    3657}
    3758
    38 .colors-icon.large .icon {
     59body:not(.mac-platform, .windows-platform) .layout-icon.large .icon {
    3960    content: -webkit-image-set(url(../Images/ColorsLarge.png) 1x, url(../Images/ColorsLarge@2x.png) 2x);
    4061}
    41 
    42 .script-icon .icon {
     62 
     63body:not(.mac-platform, .windows-platform) .script-icon .icon {
    4364    content: -webkit-image-set(url(../Images/Script.png) 1x, url(../Images/Script@2x.png) 2x);
    4465}
    45 
    46 .script-icon.large .icon {
     66 
     67body:not(.mac-platform, .windows-platform) .script-icon.large .icon {
    4768    content: -webkit-image-set(url(../Images/ScriptLarge.png) 1x, url(../Images/ScriptLarge@2x.png) 2x);
    4869}
    49 
    50 .rendering-frame-icon .icon {
     70 
     71body:not(.mac-platform, .windows-platform) .rendering-frame-icon .icon {
    5172    content: -webkit-image-set(url(../Images/Frames.png) 1x, url(../Images/Frames@2x.png) 2x);
    5273}
  • trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js

    r195999 r196151  
    7676            return "network-icon";
    7777        case WebInspector.TimelineRecord.Type.Layout:
    78             return "colors-icon";
    79         case WebInspector.TimelineRecord.Type.Memory:
    80             // FIXME: Need a new icon. For now fall through to the Script icon.
     78            return "layout-icon";
     79        case WebInspector.TimelineRecord.Type.Memory:
     80            return "memory-icon";
    8181        case WebInspector.TimelineRecord.Type.Script:
    8282            return "script-icon";
  • trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.css

    r195910 r196151  
    129129.tree-outline.large .item .icon {
    130130    width: 32px;
     131    margin-right: 6px;
    131132}
    132133
Note: See TracChangeset for help on using the changeset viewer.