Changeset 196184 in webkit


Ignore:
Timestamp:
Feb 5, 2016 1:20:52 PM (8 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: Replace all instances of '%s' with “%s“
​https://bugs.webkit.org/show_bug.cgi?id=153891
<rdar://problem/24510236>

Patch by Devin Rousso <Devin Rousso> on 2016-02-05
Reviewed by Timothy Hatcher.

Switched all WebInspector.UIString() from using to ““.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste):

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded):

  • UserInterface/Views/VisualStylePropertyEditor.js:

(WebInspector.VisualStylePropertyEditor.prototype.update):

  • UserInterface/Views/VisualStyleSelectorTreeItem.js:

(WebInspector.VisualStyleSelectorTreeItem.prototype._updateSelectorIcon):

Location:
trunk/Source/WebInspectorUI
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebInspectorUI/ChangeLog

    r196169 r196184  
     12016-02-05  Devin Rousso  <dcrousso+webkit@gmail.com>
     2
     3        Web Inspector: Replace all instances of '%s' with “%s“
     4        https://bugs.webkit.org/show_bug.cgi?id=153891
     5        <rdar://problem/24510236>
     6
     7        Reviewed by Timothy Hatcher.
     8
     9        Switched all WebInspector.UIString() from using '' to ““.
     10
     11        * Localizations/en.lproj/localizedStrings.js:
     12        * UserInterface/Views/CSSStyleDeclarationSection.js:
     13        (WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste):
     14        * UserInterface/Views/CSSStyleDeclarationTextEditor.js:
     15        (WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded):
     16        * UserInterface/Views/VisualStylePropertyEditor.js:
     17        (WebInspector.VisualStylePropertyEditor.prototype.update):
     18        * UserInterface/Views/VisualStyleSelectorTreeItem.js:
     19        (WebInspector.VisualStyleSelectorTreeItem.prototype._updateSelectorIcon):
     20
    1212016-02-05  Nikita Vasilyev  <nvasilyev@apple.com>
    222

  • trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

    r196146 r196184  
    209209localizedStrings["Detach into separate window"] = "Detach into separate window";
    210210localizedStrings["Details"] = "Details";
    211 localizedStrings["Did you mean '%s'?\nClick to replace."] = "Did you mean '%s'?\nClick to replace.";
     211localizedStrings["Did you mean “%s”?\nClick to replace."] = "Did you mean “%s”?\nClick to replace.";
    212212localizedStrings["Dimensions"] = "Dimensions";
    213213localizedStrings["Direction"] = "Direction";
    … …  
    229229localizedStrings["Download Web Archive"] = "Download Web Archive";
    230230localizedStrings["Duplicate Selector"] = "Duplicate Selector";
    231 localizedStrings["Duplicate property '%s'.\nClick to delete this property."] = "Duplicate property '%s'.\nClick to delete this property.";
     231localizedStrings["Duplicate property “%s”.\nClick to delete this property."] = "Duplicate property “%s”.\nClick to delete this property.";
    232232localizedStrings["Duration"] = "Duration";
    233233localizedStrings["Dynamically calculated for the parent element"] = "Dynamically calculated for the parent element";
    … …  
    649649localizedStrings["Text Node"] = "Text Node";
    650650localizedStrings["Text Only"] = "Text Only";
    651 localizedStrings["The 'webkit' prefix is needed for this property.\nClick to insert a duplicate with the prefix."] = "The 'webkit' prefix is needed for this property.\nClick to insert a duplicate with the prefix.";
    652 localizedStrings["The 'webkit' prefix is not necessary.\nClick to insert a duplicate without the prefix."] = "The 'webkit' prefix is not necessary.\nClick to insert a duplicate without the prefix.";
    653 localizedStrings["The property '%s' is not supported."] = "The property '%s' is not supported.";
    654 localizedStrings["The selector '%s' is invalid.\nClick to revert to the previous selector."] = "The selector '%s' is invalid.\nClick to revert to the previous selector.";
    655 localizedStrings["The value '%s' is not supported for this property."] = "The value '%s' is not supported for this property.";
    656 localizedStrings["The value '%s' is not supported for this property.\nClick to delete and open autocomplete."] = "The value '%s' is not supported for this property.\nClick to delete and open autocomplete.";
    657 localizedStrings["The value '%s' needs units.\nClick to add 'px' to the value."] = "The value '%s' needs units.\nClick to add 'px' to the value.";
     651localizedStrings["The property “%s” is not supported."] = "The property “%s” is not supported.";
     652localizedStrings["The selector “%s” is invalid.\nClick to revert to the previous selector."] = "The selector “%s” is invalid.\nClick to revert to the previous selector.";
     653localizedStrings["The value “%s” is not supported for this property."] = "The value “%s” is not supported for this property.";
     654localizedStrings["The value “%s” is not supported for this property.\nClick to delete and open autocomplete."] = "The value “%s” is not supported for this property.\nClick to delete and open autocomplete.";
     655localizedStrings["The value “%s” needs units.\nClick to add “px” to the value."] = "The value “%s” needs units.\nClick to add “px” to the value.";
    658656localizedStrings["The “%s”\ntable is empty."] = "The “%s”\ntable is empty.";
     657localizedStrings["The “webkit” prefix is needed for this property.\nClick to insert a duplicate with the prefix."] = "The “webkit” prefix is needed for this property.\nClick to insert a duplicate with the prefix.";
     658localizedStrings["The “webkit” prefix is not necessary.\nClick to insert a duplicate without the prefix."] = "The “webkit” prefix is not necessary.\nClick to insert a duplicate without the prefix.";
    659659localizedStrings["This Element"] = "This Element";
    660660localizedStrings["This property needs a value.\nClick to open autocomplete."] = "This property needs a value.\nClick to open autocomplete.";
    … …  
    696696localizedStrings["User Stylesheet"] = "User Stylesheet";
    697697localizedStrings["Using Keyword Value"] = "Using Keyword Value";
    698 localizedStrings["Using the previous selector '%s'."] = "Using the previous selector '%s'.";
     698localizedStrings["Using the previous selector “%s”."] = "Using the previous selector “%s”.";
    699699localizedStrings["Value"] = "Value";
    700700localizedStrings["Variants"] = "Variants";

  • trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js

    r194717 r196184  
    649649        }
    650650
    651         this._iconElement.title = WebInspector.UIString("The selector '%s' is invalid.\nClick to revert to the previous selector.").format(this._selectorElement.textContent.trim());
    652         this._selectorElement.title = WebInspector.UIString("Using the previous selector '%s'.").format(this._style.ownerRule.selectorText);
     651        this._iconElement.title = WebInspector.UIString("The selector “%s” is invalid.\nClick to revert to the previous selector.").format(this._selectorElement.textContent.trim());
     652        this._selectorElement.title = WebInspector.UIString("Using the previous selector “%s”.").format(this._style.ownerRule.selectorText);
    653653        for (let i = 0; i < this._selectorElement.children.length; ++i)
    654654            this._selectorElement.children[i].title = null;

  • trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js

    r194977 r196184  
    10741074            generateInvalidMarker.call(this, {
    10751075                position: from,
    1076                 title: WebInspector.UIString("The 'webkit' prefix is not necessary.\nClick to insert a duplicate without the prefix."),
     1076                title: WebInspector.UIString("The “webkit” prefix is not necessary.\nClick to insert a duplicate without the prefix."),
    10771077                correction: property.text + "\n" + property.text.replace("-webkit-", ""),
    10781078                autocomplete: false
    … …  
    10811081            invalidMarkerInfo = {
    10821082                position: from,
    1083                 title: WebInspector.UIString("Duplicate property '%s'.\nClick to delete this property.").format(property.name),
     1083                title: WebInspector.UIString("Duplicate property “%s”.\nClick to delete this property.").format(property.name),
    10841084                correction: "",
    10851085                autocomplete: false
    … …  
    11051105                invalidMarkerInfo = {
    11061106                    position: start,
    1107                     title: WebInspector.UIString("The value '%s' needs units.\nClick to add 'px' to the value.").format(property.value),
     1107                    title: WebInspector.UIString("The value “%s” needs units.\nClick to add “px” to the value.").format(property.value),
    11081108                    correction: property.name + ": " + property.value + "px;",
    11091109                    autocomplete: false
    11101110                };
    11111111            } else {
    1112                 var valueReplacement = property.value.length ? WebInspector.UIString("The value '%s' is not supported for this property.\nClick to delete and open autocomplete.").format(property.value) : WebInspector.UIString("This property needs a value.\nClick to open autocomplete.");
     1112                var valueReplacement = property.value.length ? WebInspector.UIString("The value “%s” is not supported for this property.\nClick to delete and open autocomplete.").format(property.value) : WebInspector.UIString("This property needs a value.\nClick to open autocomplete.");
    11131113
    11141114                invalidMarkerInfo = {
    … …  
    11231123            invalidMarkerInfo = {
    11241124                position: from,
    1125                 title: WebInspector.UIString("The 'webkit' prefix is needed for this property.\nClick to insert a duplicate with the prefix."),
     1125                title: WebInspector.UIString("The “webkit” prefix is needed for this property.\nClick to insert a duplicate with the prefix."),
    11261126                correction: "-webkit-" + property.text + "\n" + property.text,
    11271127                autocomplete: false
    … …  
    11351135                invalidMarkerInfo = {
    11361136                    position: from,
    1137                     title: WebInspector.UIString("Did you mean '%s'?\nClick to replace.").format(closestPropertyName),
     1137                    title: WebInspector.UIString("Did you mean “%s”?\nClick to replace.").format(closestPropertyName),
    11381138                    correction: property.text.replace(property.name, closestPropertyName),
    11391139                    autocomplete: true
    … …  
    11431143                invalidMarkerInfo = {
    11441144                    position: from,
    1145                     title: WebInspector.UIString("Did you mean '%s'?\nClick to replace.").format("-webkit-" + closestPropertyName),
     1145                    title: WebInspector.UIString("Did you mean “%s”?\nClick to replace.").format("-webkit-" + closestPropertyName),
    11461146                    correction: property.text.replace(property.canonicalName, closestPropertyName),
    11471147                    autocomplete: true
    … …  
    11511151                invalidMarkerInfo = {
    11521152                    position: from,
    1153                     title: WebInspector.UIString("The property '%s' is not supported.").format(property.name),
     1153                    title: WebInspector.UIString("The property “%s” is not supported.").format(property.name),
    11541154                    correction: false,
    11551155                    autocomplete: false

  • trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditor.js

    r196146 r196184  
    292292            if (!propertyMissing && !property.valid) {
    293293                this._warningElement.classList.add("invalid-value");
    294                 this._warningElement.title = WebInspector.UIString("The value '%s' is not supported for this property.").format(propertyText);
     294                this._warningElement.title = WebInspector.UIString("The value “%s” is not supported for this property.").format(propertyText);
    295295                this.specialPropertyPlaceholderElementText = propertyText;
    296296                return;

  • trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorTreeItem.js

    r194737 r196184  
    262262        this._listItemNode.classList.toggle("selector-invalid", !!this._hasInvalidSelector);
    263263        if (this._hasInvalidSelector) {
    264             this._iconElement.title = WebInspector.UIString("The selector '%s' is invalid.\nClick to revert to the previous selector.").format(this.selectorText);
    265             this.mainTitleElement.title = WebInspector.UIString("Using the previous selector '%s'.").format(this.representedObject.ownerRule.selectorText);
     264            this._iconElement.title = WebInspector.UIString("The selector “%s” is invalid.\nClick to revert to the previous selector.").format(this.selectorText);
     265            this.mainTitleElement.title = WebInspector.UIString("Using the previous selector “%s”.").format(this.representedObject.ownerRule.selectorText);
    266266            return;
    267267        }
Note: See TracChangeset for help on using the changeset viewer.