Changeset 196234 in webkit

Timestamp:

Feb 6, 2016 6:03:22 PM (8 years ago)

Author:

dbates@webkit.org

Message:

Call CFRelease() on SecRequirementRef when no longer needed
​https://bugs.webkit.org/show_bug.cgi?id=153954
<rdar://problem/24540259>

Reviewed by Dan Bernstein.

• Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::initializeSandbox):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/mac/ChildProcessMac.mm (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-02-06  Daniel Bates  <dabates@apple.com>
+
+        Call CFRelease() on SecRequirementRef when no longer needed
+        https://bugs.webkit.org/show_bug.cgi?id=153954
+        <rdar://problem/24540259>
+
+        Reviewed by Dan Bernstein.
+
+        * Shared/mac/ChildProcessMac.mm:
+        (WebKit::ChildProcess::initializeSandbox):
+
 2016-02-06  Darin Adler  <darin@apple.com>
 

trunk/Source/WebKit2/Shared/mac/ChildProcessMac.mm

@@ -103 +103 @@
 
             CFStringRef appleSignedOrMacAppStoreSignedOrAppleDeveloperSignedRequirement = CFSTR("(anchor apple) or (anchor apple generic and certificate leaf[field.1.2.840.113635.100.6.1.9]) or (anchor apple generic and certificate 1[field.1.2.840.113635.100.6.2.6] and certificate leaf[field.1.2.840.113635.100.6.1.13])");
-            SecRequirementRef signingRequirement;
+            SecRequirementRef signingRequirement = nullptr;
             OSStatus status = SecRequirementCreateWithString(appleSignedOrMacAppStoreSignedOrAppleDeveloperSignedRequirement, kSecCSDefaultFlags, &signingRequirement);
             RELEASE_ASSERT(status == errSecSuccess);
@@ -127 +127 @@
                 sandboxParameters.setUserDirectorySuffix(makeString(String([[NSBundle mainBundle] bundleIdentifier]), '+', parameters.clientIdentifier));
             }
+            CFRelease(signingRequirement);
         } else {
             // Legacy client