Changeset 196238 in webkit

Timestamp:

Feb 7, 2016 2:09:31 AM (8 years ago)

Author:

Carlos Garcia Campos

Message:

REGRESSION(r195661): [GTK] Scrollbar tests crashing after overlay scrollbar groundwork
​https://bugs.webkit.org/show_bug.cgi?id=153695

Reviewed by Michael Catanzaro.

Source/WebCore:

The problem is that ScrollAnimation objects are not destroyed by
the ScrollAnimator destructor, because I forgot to add a virtual
destructor for ScrollAnimation in r195661.

• platform/ScrollAnimation.h:

(WebCore::ScrollAnimation::~ScrollAnimation):

LayoutTests:

• platform/gtk/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/ScrollAnimation.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-02-07  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r195661): [GTK] Scrollbar tests crashing after overlay scrollbar groundwork
+        https://bugs.webkit.org/show_bug.cgi?id=153695
+
+        Reviewed by Michael Catanzaro.
+
+        * platform/gtk/TestExpectations:
+
 2016-02-06  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -735 +735 @@
 
 webkit.org/b/153692 imported/blink/fast/css/first-letter-float-block.html [ Crash Pass ]
-
-webkit.org/b/153695 fast/repaint/fixed-move-after-scroll.html [ Crash Pass ]
-webkit.org/b/153695 fast/scrolling/scroll-position-on-reload-rtl.html [ Crash Pass ]
-webkit.org/b/153695 scrollbars/scrollbar-initial-position.html [ Crash Pass ]
-
-webkit.org/b/153936 editing/input/password-echo-passnode2.html [ Crash Pass ]
 
 webkit.org/b/117756 media/track/media-element-enqueue-event-crash.html [ Timeout Pass Crash ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-02-07  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r195661): [GTK] Scrollbar tests crashing after overlay scrollbar groundwork
+        https://bugs.webkit.org/show_bug.cgi?id=153695
+
+        Reviewed by Michael Catanzaro.
+
+        The problem is that ScrollAnimation objects are not destroyed by
+        the ScrollAnimator destructor, because I forgot to add a virtual
+        destructor for ScrollAnimation in r195661.
+
+        * platform/ScrollAnimation.h:
+        (WebCore::ScrollAnimation::~ScrollAnimation):
+
 2016-02-06  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/ScrollAnimation.h

@@ -36 +36 @@
 class ScrollAnimation {
 public:
+    virtual ~ScrollAnimation() { };
     virtual bool scroll(ScrollbarOrientation, ScrollGranularity, float step, float multiplier) = 0;
     virtual void stop() = 0;