Changeset 196257 in webkit

Timestamp:

Feb 8, 2016 10:43:18 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Fix crash when creating webview with g_object_new
​https://bugs.webkit.org/show_bug.cgi?id=153989

Patch by Danilo Cesar Lemes de Paula <​danilo.cesar@collabora.co.uk> on 2016-02-08
Reviewed by Carlos Garcia Campos.

g_object_new(WEBKIT_TYPE_WEB_VIEW, NULL) crashes webkit
as _WebKitWebViewBasePrivate constructor requires a mainloop, but
webkit is only initialized when a context is created (which
doesn't happen with a direct call to g_object_new).

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkit_web_view_base_class_init):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/gtk/WebKitWebViewBase.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-02-08  Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
+
+        [GTK] Fix crash when creating webview with g_object_new
+        https://bugs.webkit.org/show_bug.cgi?id=153989
+
+        Reviewed by Carlos Garcia Campos.
+
+        g_object_new(WEBKIT_TYPE_WEB_VIEW, NULL) crashes webkit
+        as _WebKitWebViewBasePrivate constructor requires a mainloop, but
+        webkit is only initialized when a context is created (which
+        doesn't happen with a direct call to g_object_new).
+
+        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
+        (webkit_web_view_base_class_init):
+
 2016-02-08  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp

@@ -43 +43 @@
 #include "WebFullScreenClientGtk.h"
 #include "WebInspectorProxy.h"
+#include "WebKit2Initialize.h"
 #include "WebKitAuthenticationDialog.h"
 #include "WebKitPrivate.h"
@@ -1103 +1104 @@
     containerClass->remove = webkitWebViewBaseContainerRemove;
     containerClass->forall = webkitWebViewBaseContainerForall;
+
+    // Before creating a WebKitWebViewBasePriv we need to be sure that WebKit is started.
+    // Usually starting a context triggers InitializeWebKit2, but in case
+    // we create a view without asking before for a default_context we get a crash.
+    WebKit::InitializeWebKit2();
 }