Changeset 19626 in webkit

Timestamp:

Feb 14, 2007 11:02:36 AM (17 years ago)

Author:

antti

Message:

LayoutTests:

Reviewed by Maciej.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=11974 REGRESSION: Caret drawn over input when smaller than font size on initial focus <rdar://problem/4960258>

• fast/forms/textfield-overflow-expected.checksum: Added.
• fast/forms/textfield-overflow-expected.png: Added.
• fast/forms/textfield-overflow-expected.txt: Added.
• fast/forms/textfield-overflow.html: Added.

WebCore:

Reviewed by Maciej.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11974 REGRESSION: Caret drawn over input when smaller than font size on initial focus <rdar://problem/4960258>

Set controlClip for non-search text controls.

• rendering/RenderTextControl.h: (WebCore::RenderTextControl::hasControlClip):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/textfield-overflow-expected.checksum (added)
• LayoutTests/fast/forms/textfield-overflow-expected.png (added)
• LayoutTests/fast/forms/textfield-overflow-expected.txt (added)
• LayoutTests/fast/forms/textfield-overflow.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderTextControl.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-02-14  Antti Koivisto  <antti@apple.com>
+
+        Reviewed by Maciej.
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=11974
+        REGRESSION: Caret drawn over input when smaller than font size on initial focus
+        <rdar://problem/4960258>
+
+        * fast/forms/textfield-overflow-expected.checksum: Added.
+        * fast/forms/textfield-overflow-expected.png: Added.
+        * fast/forms/textfield-overflow-expected.txt: Added.
+        * fast/forms/textfield-overflow.html: Added.
+
 2007-02-14  Geoffrey Garen  <ggaren@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-02-14  Antti Koivisto  <antti@apple.com>
+
+        Reviewed by Maciej.
+        
+        - fix http://bugs.webkit.org/show_bug.cgi?id=11974
+        REGRESSION: Caret drawn over input when smaller than font size on initial focus
+        <rdar://problem/4960258>
+        
+        Set controlClip for non-search text controls.
+
+        * rendering/RenderTextControl.h:
+        (WebCore::RenderTextControl::hasControlClip):
+
 2007-02-14  Mitz Pettel  <mitz@webkit.org>
 

trunk/WebCore/rendering/RenderTextControl.h

@@ -52 +52 @@
     virtual void layout();
     virtual bool avoidsFloats() const { return true; }
+    virtual bool hasControlClip() const { return !m_innerBlock; }
 
     virtual bool isEdited() const { return m_dirty; }